Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2854293002: Enable waterfall testing for DesktopIOSPromotion. (Closed)

Created:
3 years, 7 months ago by jasonkliu
Modified:
3 years, 7 months ago
CC:
chromium-reviews, gchatz, mrefaat, pkl (ping after 24h if needed), justincohen
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable waterfall testing for DesktopIOSPromotion. This is in preparation for beta and stable Finch configs. BUG=676655 Review-Url: https://codereview.chromium.org/2854293002 Cr-Commit-Position: refs/heads/master@{#469292} Committed: https://chromium.googlesource.com/chromium/src/+/813e697704faf15bfbc14d8381d8f06eda85c86a

Patch Set 1 #

Patch Set 2 : Add SavePasswordsBubblePromotion50Beta config. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config.json View 1 1 chunk +65 lines, -0 lines 1 comment Download

Messages

Total messages: 9 (5 generated)
jasonkliu
3 years, 7 months ago (2017-05-03 15:33:49 UTC) #3
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/2854293002/diff/20001/testing/variations/fieldtrial_testing_config.json File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2854293002/diff/20001/testing/variations/fieldtrial_testing_config.json#newcode705 testing/variations/fieldtrial_testing_config.json:705: "name": "SavePasswordsBubblePromotionV1", Not: The first one will be ...
3 years, 7 months ago (2017-05-03 19:03:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854293002/20001
3 years, 7 months ago (2017-05-04 06:44:09 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 07:52:09 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/813e697704faf15bfbc14d8381d8...

Powered by Google App Engine
This is Rietveld 408576698