Removing more noise from user action sequencer.

Removing more noise from user action sequencer.

Launcher_ClickOnAppListButton is generated both on launcher start and closing. Replaced (in sequencer) with Launcher_Show (new) and Launcher_Dismiss (see prev CL) pair.

Bug=712331
Review-Url: https://codereview.chromium.org/2854283005
Cr-Commit-Position: refs/heads/master@{#469477}
Committed: https://chromium.googlesource.com/chromium/src/+/d01fb51d1a9ba850c92f525dc31187ef79a2586c

[vadimt, 2017-05-03 19:10:19]

vadimt@chromium.org changed reviewers:
+ rkaplow@chromium.org, xiyuan@chromium.org

[rkaplow, 2017-05-04 15:41:26]

lgtm

[xiyuan, 2017-05-04 19:59:14]

Launcher_ClickOnAppListButton means user has clicked on the app list button on
the shelf. The click toggles the app list visibility. So it is expected that two
actions are recorded when clicking on the app list button once to show and once
to hide launcher.

What is the problem with that?

[vadimt, 2017-05-04 20:33:36]

On exit, first Launcher_Dismiss gets generated, and then
Launcher_ClickOnAppListButton, and it's not easy to change this order.
So of you use Sequencer starting with Launcher_ClickOnAppListButton, you'll get
both events that follow both after starting launcher and after closing, which
creates mess. So, there is no good way to see what happens after starting
Launcher.

[xiyuan, 2017-05-04 20:46:12]

lgtm

[vadimt, 2017-05-04 20:46:36]

The CQ bit was checked by vadimt@chromium.org

[commit-bot: I haz the power, 2017-05-04 20:47:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 21:24:19]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493930796906470, "parent_rev":
"4d71e46c292ec537736a813991cfb3b641cacf65", "commit_rev":
"d01fb51d1a9ba850c92f525dc31187ef79a2586c"}

[commit-bot: I haz the power, 2017-05-04 21:24:29]

Description was changed from

==========
Removing more noise from user action sequencer.

Launcher_ClickOnAppListButton is generated both on launcher start and closing.
Replaced (in sequencer) with Launcher_Show (new) and Launcher_Dismiss (see prev
CL) pair.

Bug=712331
==========

to

==========
Removing more noise from user action sequencer.

Launcher_ClickOnAppListButton is generated both on launcher start and closing.
Replaced (in sequencer) with Launcher_Show (new) and Launcher_Dismiss (see prev
CL) pair.

Bug=712331

Review-Url: https://codereview.chromium.org/2854283005
Cr-Commit-Position: refs/heads/master@{#469477}
Committed:
https://chromium.googlesource.com/chromium/src/+/d01fb51d1a9ba850c92f525dc311...
==========

[commit-bot: I haz the power, 2017-05-04 21:24:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d01fb51d1a9ba850c92f525dc311...