Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2854273004: Reduce binary size of Builtins::CallableFor (Closed)

Created:
3 years, 7 months ago by Jakob Kummerow
Modified:
3 years, 7 months ago
Reviewers:
Camillo Bruni
CC:
jgruber, v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Reduce binary size of Builtins::CallableFor by pulling parameterizable things out of the case-blocks. No change in functionality. BUG=chromium:714894 Review-Url: https://codereview.chromium.org/2854273004 Cr-Commit-Position: refs/heads/master@{#45066} Committed: https://chromium.googlesource.com/v8/v8/+/133ef93afa74f1d08919c89b358b8e0da5323cdb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M src/builtins/builtins.cc View 1 chunk +11 lines, -6 lines 0 comments Download
M src/interface-descriptors.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Jakob Kummerow
Camillo: PTAL. Jakob: FYI.
3 years, 7 months ago (2017-05-03 14:30:34 UTC) #2
Camillo Bruni
lgtm
3 years, 7 months ago (2017-05-03 14:33:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854273004/1
3 years, 7 months ago (2017-05-03 14:34:02 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 15:02:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/133ef93afa74f1d08919c89b358b8e0da53...

Powered by Google App Engine
This is Rietveld 408576698