Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 2854263006: Remove non-target version of copyVideoTextureToPlatformTexture (Closed)

Created:
3 years, 7 months ago by jiajia.qin
Modified:
3 years, 7 months ago
CC:
apacible+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-html_chromium.org, chfremer+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, eric.carlson_apple.com, erickung+watch_chromium.org, feature-media-reviews_chromium.org, jam, mfoltz+watch_chromium.org, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org, Srirama, xjz+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove non-target version of copyVideoTextureToPlatformTexture BUG=349871 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2854263006 Cr-Commit-Position: refs/heads/master@{#471166} Committed: https://chromium.googlesource.com/chromium/src/+/c294316ee266826158935c2fadadfd447b4a3a31

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -37 lines) Patch
M content/renderer/media/webmediaplayer_ms.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M media/renderers/skcanvas_video_renderer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M media/renderers/skcanvas_video_renderer.cc View 7 chunks +21 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebMediaPlayer.h View 1 chunk +2 lines, -14 lines 0 comments Download

Messages

Total messages: 31 (17 generated)
jiajia.qin
Hi, Yunchao. Please take a first look. It seems that the try-bot is not very ...
3 years, 7 months ago (2017-05-09 03:20:52 UTC) #11
yunchao
On 2017/05/09 03:20:52, jiajia.qin wrote: > Hi, Yunchao. Please take a first look. It seems ...
3 years, 7 months ago (2017-05-10 08:34:46 UTC) #12
jiajia.qin
Please take a look. Thanks.
3 years, 7 months ago (2017-05-10 08:48:52 UTC) #14
Zhenyao Mo
On 2017/05/10 08:48:52, jiajia.qin wrote: > Please take a look. Thanks. lgtm, but I am ...
3 years, 7 months ago (2017-05-10 18:07:50 UTC) #15
jiajia.qin
@sandersd @jochen @dshwang Please take a look. Thanks.
3 years, 7 months ago (2017-05-11 01:23:30 UTC) #17
jochen (gone - plz use gerrit)
which files would you like me to review?
3 years, 7 months ago (2017-05-11 07:55:22 UTC) #18
jiajia.qin
On 2017/05/11 07:55:22, jochen wrote: > which files would you like me to review? jochen: ...
3 years, 7 months ago (2017-05-11 08:03:06 UTC) #19
sandersd (OOO until July 31)
lgtm
3 years, 7 months ago (2017-05-11 20:59:38 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854263006/1
3 years, 7 months ago (2017-05-11 23:39:34 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/434791)
3 years, 7 months ago (2017-05-12 00:19:45 UTC) #24
haraken
On 2017/05/12 00:19:45, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 7 months ago (2017-05-12 00:34:35 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854263006/1
3 years, 7 months ago (2017-05-12 00:42:10 UTC) #27
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c294316ee266826158935c2fadadfd447b4a3a31
3 years, 7 months ago (2017-05-12 01:34:56 UTC) #30
Ken Russell (switch to Gerrit)
3 years, 7 months ago (2017-05-16 00:40:42 UTC) #31
Message was sent while issue was closed.
Thanks for this cleanup.

Powered by Google App Engine
This is Rietveld 408576698