components/resources/security_interstitials_resources.grdp - Issue 2854263003: Add quiet safe browsing interstitial for WebView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/resources/security_interstitials_resources.grdp

Issue 2854263003: Add quiet safe browsing interstitial for WebView (Closed)

Patch Set: Fix tests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/neterror/resources/neterror.html ('k') | components/safe_browsing/base_blocking_page.cc » ('j') | components/security_interstitials/core/browser/resources/interstitial_common.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/resources/security_interstitials_resources.grdp

diff --git a/components/resources/security_interstitials_resources.grdp b/components/resources/security_interstitials_resources.grdp

index 907ef5fe0fcf5edbadbf2051555b04cc4d31a58a..2fb0f05ce92147674cb475aa8320d1cb168d2609 100644

--- a/components/resources/security_interstitials_resources.grdp

+++ b/components/resources/security_interstitials_resources.grdp

@@ -2,4 +2,5 @@

<grit-part>

+ <include name="IDR_SECURITY_INTERSTITIAL_QUIET_HTML" file="../security_interstitials/core/browser/resources/interstitial_webview_quiet.html" flattenhtml="true" type="BINDATA" />

Dan Beam 2017/05/19 19:14:22 do you need to flattenhtml="true"? are you relyin

edwardjung 2017/05/19 19:38:18 Yes they need to be inlined, they aren't normal We

</grit-part>