components/resources/security_interstitials_resources.grdp - Issue 2854263003: Add quiet safe browsing interstitial for WebView

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/resources/security_interstitials_resources.grdp

Issue 2854263003: Add quiet safe browsing interstitial for WebView (Closed)

Patch Set: Fix tests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/neterror/resources/neterror.html ('k') | components/safe_browsing/base_blocking_page.cc » ('j') | components/security_interstitials/core/browser/resources/interstitial_common.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <grit-part>	2 <grit-part>

3 <include name="IDR_SECURITY_INTERSTITIAL_UI_HTML" file="../security_interstiti als/core/browser/resources/interstitial_ui.html" flattenhtml="true" type="BINDAT A" />	3 <include name="IDR_SECURITY_INTERSTITIAL_UI_HTML" file="../security_interstiti als/core/browser/resources/interstitial_ui.html" flattenhtml="true" type="BINDAT A" />

4 <include name="IDR_SECURITY_INTERSTITIAL_HTML" file="../security_interstitials /core/browser/resources/interstitial_v2.html" flattenhtml="true" type="BINDATA" />	4 <include name="IDR_SECURITY_INTERSTITIAL_HTML" file="../security_interstitials /core/browser/resources/interstitial_v2.html" flattenhtml="true" type="BINDATA" />

	5 <include name="IDR_SECURITY_INTERSTITIAL_QUIET_HTML" file="../security_interst itials/core/browser/resources/interstitial_webview_quiet.html" flattenhtml="true " type="BINDATA" />
	Dan Beam 2017/05/19 19:14:22 do you need to flattenhtml="true"? are you relyin do you need to flattenhtml="true"? are you relying on resources being inlined? edwardjung 2017/05/19 19:38:18 Yes they need to be inlined, they aren't normal We Show quoted text On 2017/05/19 19:14:22, Dan Beam wrote: > do you need to flattenhtml="true"? are you relying on resources being inlined? Yes they need to be inlined, they aren't normal WebUI pages, the interstitials can't reference external resources via chrome:// as they are blocked. This page replaces the site the user would have seen.
5 </grit-part>	6 </grit-part>

OLD	NEW