Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2854243003: Use constexpr TaskTraits constructor in net. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
gab, Jana
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, ios-reviews_chromium.org, gavinp+disk_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use constexpr TaskTraits constructor in net. Use a constexpr constructor that accepts traits in any order instead of the builder pattern to construct TaskTraits in net. BUG=713683 R=gab@chromium.org TBR=jri@chromium.org Review-Url: https://codereview.chromium.org/2854243003 Cr-Commit-Position: refs/heads/master@{#469180} Committed: https://chromium.googlesource.com/chromium/src/+/2f60799d8cb1d8a99ba1b3a04156dc30de276272

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -33 lines) Patch
M net/base/directory_lister.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/disk_cache/blockfile/file_ios.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M net/disk_cache/cache_util.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M net/dns/address_sorter_win.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M net/proxy/polling_proxy_config_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/socket/tcp_socket_posix.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/ssl/channel_id_service.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M net/url_request/url_fetcher_impl_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/url_request/url_request_simple_job.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
fdoray
3 years, 7 months ago (2017-05-03 20:24:50 UTC) #1
fdoray
gab@: PTAL The change will then be TBRed to the owner.
3 years, 7 months ago (2017-05-03 20:24:52 UTC) #3
gab
lgtm
3 years, 7 months ago (2017-05-03 20:39:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854243003/1
3 years, 7 months ago (2017-05-03 20:43:33 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 22:55:18 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2f60799d8cb1d8a99ba1b3a04156...

Powered by Google App Engine
This is Rietveld 408576698