Make in process stack dumping optional.

d8: Make in process stack dumping optional

Adds a flag (--disable-in-process-stack-traces) to not install
signal handlers so that e.g. ASan signal handlers will work.

This flag mirrors chromium's one.

R=jochen@chromium.org
BUG=chromium:716235
Review-Url: https://codereview.chromium.org/2854173002
Cr-Commit-Position: refs/heads/master@{#45142}
Committed: https://chromium.googlesource.com/v8/v8/+/3f4536894ac3001c53256d08d1e85aa442eb0f02

[Oliver Chang, 2017-05-02 17:28:36]

PTAL. this flag mirrors --disable-in-process-stack-traces in chromium.

We need this to get ASan stacktraces for d8 crashes.

[Oliver Chang, 2017-05-02 20:45:38]

Description was changed from

==========
Make in process stack dumping optional.

R=jochen@chromium.org
BUG=chromium:716235
==========

to

==========
Make in process stack dumping optional.

Adds a flag (--disable_in_process_stack_traces) to not install
signal handlers so that e.g. ASan signal handlers will work.

R=jochen@chromium.org
BUG=chromium:716235
==========

[jochen (gone - plz use gerrit), 2017-05-03 10:42:08]

https://codereview.chromium.org/2854173002/diff/1/include/libplatform/libplat...
File include/libplatform/libplatform.h (right):

https://codereview.chromium.org/2854173002/diff/1/include/libplatform/libplat...
include/libplatform/libplatform.h:31: bool in_process_stack_dumping = true);
please make this an enum class instead of a bool

https://codereview.chromium.org/2854173002/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/2854173002/diff/1/src/flag-definitions.h#newc...
src/flag-definitions.h:1049: "Disable in process stack traces.")
instead of adding a flag to v8 itself, just add one to Shell::SetOptions in
d8.cc

[inferno, 2017-05-03 15:19:21]

inferno@chromium.org changed reviewers:
+ inferno@chromium.org

[Oliver Chang, 2017-05-03 16:22:08]

Description was changed from

==========
Make in process stack dumping optional.

Adds a flag (--disable_in_process_stack_traces) to not install
signal handlers so that e.g. ASan signal handlers will work.

R=jochen@chromium.org
BUG=chromium:716235
==========

to

==========
d8: Make in process stack dumping optional

Adds a flag (--disable-in-process-stack-traces) to not install
signal handlers so that e.g. ASan signal handlers will work.

This flag mirrors chromium's one.

R=jochen@chromium.org
BUG=chromium:716235
==========

[Oliver Chang, 2017-05-03 16:25:19]

https://codereview.chromium.org/2854173002/diff/1/include/libplatform/libplat...
File include/libplatform/libplatform.h (right):

https://codereview.chromium.org/2854173002/diff/1/include/libplatform/libplat...
include/libplatform/libplatform.h:31: bool in_process_stack_dumping = true);
On 2017/05/03 10:42:08, jochen wrote:
> please make this an enum class instead of a bool

Done.

https://codereview.chromium.org/2854173002/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/2854173002/diff/1/src/flag-definitions.h#newc...
src/flag-definitions.h:1049: "Disable in process stack traces.")
On 2017/05/03 10:42:08, jochen wrote:
> instead of adding a flag to v8 itself, just add one to Shell::SetOptions in
> d8.cc

Done.

[jochen (gone - plz use gerrit), 2017-05-05 14:23:42]

lgtm

[Oliver Chang, 2017-05-05 15:33:07]

The CQ bit was checked by ochang@chromium.org

[commit-bot: I haz the power, 2017-05-05 15:33:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 16:00:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493998387302660,
"parent_rev": "f0e95769dbc3c209f513c68e2aa7c9433c4cd934", "commit_rev":
"3f4536894ac3001c53256d08d1e85aa442eb0f02"}

[commit-bot: I haz the power, 2017-05-05 16:00:36]

Description was changed from

==========
d8: Make in process stack dumping optional

Adds a flag (--disable-in-process-stack-traces) to not install
signal handlers so that e.g. ASan signal handlers will work.

This flag mirrors chromium's one.

R=jochen@chromium.org
BUG=chromium:716235
==========

to

==========
d8: Make in process stack dumping optional

Adds a flag (--disable-in-process-stack-traces) to not install
signal handlers so that e.g. ASan signal handlers will work.

This flag mirrors chromium's one.

R=jochen@chromium.org
BUG=chromium:716235

Review-Url: https://codereview.chromium.org/2854173002
Cr-Commit-Position: refs/heads/master@{#45142}
Committed:
https://chromium.googlesource.com/v8/v8/+/3f4536894ac3001c53256d08d1e85aa442e...
==========

[commit-bot: I haz the power, 2017-05-05 16:00:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/3f4536894ac3001c53256d08d1e85aa442e...