Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2854143003: Fix incorrectly rounded page size (Closed)

Created:
3 years, 7 months ago by atotic
Modified:
3 years, 7 months ago
Reviewers:
eae
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix incorrectly rounded page size. Internal page size for Letter sized pages was 1054px instead of 1056px. kPrintingMinimumShrinkFactor of 1.333f was not enough precision. It caused incorrect rounding inside of ResizePageRectsKeepingRatio. Changing the constant makes page size correct. BUG=716548 Review-Url: https://codereview.chromium.org/2854143003 Cr-Commit-Position: refs/heads/master@{#468823} Committed: https://chromium.googlesource.com/chromium/src/+/78d293247b9fdde885702c3e9a879e8710e131f8

Patch Set 1 #

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/page/PrintContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
atotic
PTAL I was curious about printing, and I learned a bit how it's done by ...
3 years, 7 months ago (2017-05-02 19:44:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854143003/1
3 years, 7 months ago (2017-05-02 19:45:16 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-02 19:45:17 UTC) #7
eae
Nice, LGTM
3 years, 7 months ago (2017-05-02 19:49:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854143003/1
3 years, 7 months ago (2017-05-02 19:56:44 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/361437)
3 years, 7 months ago (2017-05-02 21:02:30 UTC) #12
atotic
On 2017/05/02 at 21:02:30, commit-bot wrote: > Try jobs failed on following builders: > linux_chromium_asan_rel_ng ...
3 years, 7 months ago (2017-05-02 21:49:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854143003/20001
3 years, 7 months ago (2017-05-02 21:50:08 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 23:49:33 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/78d293247b9fdde885702c3e9a87...

Powered by Google App Engine
This is Rietveld 408576698