Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2854123004: Hoist layout update out of SVGGraphicsElement::GetBBox and overrides (Closed)

Created:
3 years, 7 months ago by fs
Modified:
3 years, 7 months ago
Reviewers:
Stephen Chennney
CC:
fs, blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, krit, eae+blinkwatch, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Hoist layout update out of SVGGraphicsElement::GetBBox and overrides Call Document::UpdateStyleAndLayoutIgnorePendingStylesheets() in the DOM entrypoint instead of in each GetBBox implementation/override. Add DCHECKs as needed in the GetBBox implementations instead to assert the precondition. Adjust ResizeObservation::ComputeTargetSize (which shouldn't need to update the layout anyway) to account for this. Review-Url: https://codereview.chromium.org/2854123004 Cr-Commit-Position: refs/heads/master@{#469061} Committed: https://chromium.googlesource.com/chromium/src/+/10404c06ed23864a5d180e2ecab206bb39d18a45

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -21 lines) Patch
M third_party/WebKit/Source/core/dom/ResizeObservation.cpp View 1 chunk +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp View 1 chunk +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
fs
3 years, 7 months ago (2017-05-03 15:23:00 UTC) #5
Stephen Chennney
lgtm
3 years, 7 months ago (2017-05-03 18:32:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854123004/1
3 years, 7 months ago (2017-05-03 18:58:50 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 19:05:49 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/10404c06ed23864a5d180e2ecab2...

Powered by Google App Engine
This is Rietveld 408576698