Fix feedback to populate the right content in issue creation page.

Fix feedback to populate the right content in issue creation page.

Previously, server url is 'storage.googleapis.com'. And the issue
creation page can include the current page url in the description of the
issue. However then we start to use 'storage.cloud.google.com', which
will automatically redirect to a temporary signed url when visiting the
page. Thus including the temporary signed url in the issue creation page
is not useful.

In this cl, we generate the result details link when we create the html
file. And as a result is able to include the original page url, not the
signed url in the description.

BUG=717634
Review-Url: https://codereview.chromium.org/2854083004
Cr-Commit-Position: refs/heads/master@{#470078}
Committed: https://chromium.googlesource.com/chromium/src/+/29948291955ddcd6c0cba23173c06e072585db29

[jbudorick, 2017-05-04 18:09:27]

jbudorick@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2017-05-04 18:09:27]

lgtm w/ nit

https://codereview.chromium.org/2854083004/diff/20001/build/android/pylib/res...
File build/android/pylib/results/presentation/test_results_presentation.py
(right):

https://codereview.chromium.org/2854083004/diff/20001/build/android/pylib/res...
build/android/pylib/results/presentation/test_results_presentation.py:254:
return ('https://bugs.chromium.org/p/chromium/issues/entry?'
nit: this might be a bit more readable if you handle the query portion of the
URL with https://docs.python.org/2/library/urllib.html#urllib.urlencode

[BigBossZhiling, 2017-05-05 21:57:16]

The CQ bit was checked by hzl@google.com

[BigBossZhiling, 2017-05-05 21:57:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/2854083004/#ps40001
(title: "use urllib.urlencode")

[BigBossZhiling, 2017-05-05 21:57:58]

https://codereview.chromium.org/2854083004/diff/20001/build/android/pylib/res...
File build/android/pylib/results/presentation/test_results_presentation.py
(right):

https://codereview.chromium.org/2854083004/diff/20001/build/android/pylib/res...
build/android/pylib/results/presentation/test_results_presentation.py:254:
return ('https://bugs.chromium.org/p/chromium/issues/entry?'
On 2017/05/04 18:09:27, jbudorick wrote:
> nit: this might be a bit more readable if you handle the query portion of the
> URL with https://docs.python.org/2/library/urllib.html#urllib.urlencode

Done.

[commit-bot: I haz the power, 2017-05-05 21:58:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 22:04:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 22:04:57]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[BigBossZhiling, 2017-05-05 23:25:23]

after sync with case's code

[BigBossZhiling, 2017-05-05 23:25:35]

Description was changed from

==========
Fix feedback to populate the right content in issue creation page.

Previously, server url is 'storage.googleapis.com'. And the issue
creation page can include the current page url in the description of the
issue. However then we start to use 'storage.cloud.google.com', which
will automatically redirect to a temporary signed url when visiting the
page. Thus including the temporary signed url in the issue creation page
is not useful.

In this cl, we generate the result details link when we create the html
file. And as a result is able to include the original page url, not the
signed url in the description.

BUG=717634
==========

to

==========
Fix feedback to populate the right content in issue creation page.

Previously, server url is 'storage.googleapis.com'. And the issue
creation page can include the current page url in the description of the
issue. However then we start to use 'storage.cloud.google.com', which
will automatically redirect to a temporary signed url when visiting the
page. Thus including the temporary signed url in the issue creation page
is not useful.

In this cl, we generate the result details link when we create the html
file. And as a result is able to include the original page url, not the
signed url in the description.

BUG=717634
==========

[BigBossZhiling, 2017-05-05 23:25:35]

hzl@google.com changed reviewers:
+ mikecase@chromium.org

[jbudorick, 2017-05-08 17:28:10]

rebase lgtm w/ nit

https://codereview.chromium.org/2854083004/diff/80001/build/android/pylib/res...
File build/android/pylib/results/presentation/test_results_presentation.py
(right):

https://codereview.chromium.org/2854083004/diff/80001/build/android/pylib/res...
build/android/pylib/results/presentation/test_results_presentation.py:405:
upload_to_google_bucket(
Check the result of this against result_details_link.

[BigBossZhiling, 2017-05-08 18:10:54]

The CQ bit was checked by hzl@google.com

[BigBossZhiling, 2017-05-08 18:10:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/2854083004/#ps100001
(title: "add assertion to check links")

[commit-bot: I haz the power, 2017-05-08 18:11:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 19:44:01]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1494267054064850,
"parent_rev": "8d71c3f18e3cbd26ff486e2223745995573cb5f6", "commit_rev":
"29948291955ddcd6c0cba23173c06e072585db29"}

[commit-bot: I haz the power, 2017-05-08 19:45:15]

Description was changed from

==========
Fix feedback to populate the right content in issue creation page.

Previously, server url is 'storage.googleapis.com'. And the issue
creation page can include the current page url in the description of the
issue. However then we start to use 'storage.cloud.google.com', which
will automatically redirect to a temporary signed url when visiting the
page. Thus including the temporary signed url in the issue creation page
is not useful.

In this cl, we generate the result details link when we create the html
file. And as a result is able to include the original page url, not the
signed url in the description.

BUG=717634
==========

to

==========
Fix feedback to populate the right content in issue creation page.

Previously, server url is 'storage.googleapis.com'. And the issue
creation page can include the current page url in the description of the
issue. However then we start to use 'storage.cloud.google.com', which
will automatically redirect to a temporary signed url when visiting the
page. Thus including the temporary signed url in the issue creation page
is not useful.

In this cl, we generate the result details link when we create the html
file. And as a result is able to include the original page url, not the
signed url in the description.

BUG=717634

Review-Url: https://codereview.chromium.org/2854083004
Cr-Commit-Position: refs/heads/master@{#470078}
Committed:
https://chromium.googlesource.com/chromium/src/+/29948291955ddcd6c0cba23173c0...
==========

[commit-bot: I haz the power, 2017-05-08 19:45:18]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/29948291955ddcd6c0cba23173c0...