Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2854043002: Make Range::TextQuads() to use ComputeTextBounds() template function. (Closed)

Created:
3 years, 7 months ago by tanvir
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Range::TextQuads() to use ComputeTextBounds() template function. This is CL#3 to achieve the template behaviour for Range::textQuads and Range::textRects. CL#2(https://codereview.chromium.org/2839633002/) ComputeTextBounds(), template and was used by Range::computeTextRects() only. This CL set will make Range::textQuads() to use ComputeTextBounds() template. BUG=691198 Review-Url: https://codereview.chromium.org/2854043002 Cr-Commit-Position: refs/heads/master@{#470345} Committed: https://chromium.googlesource.com/chromium/src/+/f37555b2599b65017770d88c79ed9b4aae097e45

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed Review Comments #

Total comments: 6

Patch Set 3 : Addressed Review Comments #

Total comments: 2

Patch Set 4 : updated with nit's #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -20 lines) Patch
M third_party/WebKit/Source/core/dom/Range.cpp View 1 2 3 2 chunks +16 lines, -20 lines 0 comments Download

Messages

Total messages: 29 (17 generated)
tanvir
PTAL!!!
3 years, 7 months ago (2017-05-02 11:34:41 UTC) #5
Srirama
peer review is fine
3 years, 7 months ago (2017-05-02 11:37:06 UTC) #6
Xiaocheng
Thanks for the patch. https://codereview.chromium.org/2854043002/diff/1/third_party/WebKit/Source/core/dom/Range.cpp File third_party/WebKit/Source/core/dom/Range.cpp (left): https://codereview.chromium.org/2854043002/diff/1/third_party/WebKit/Source/core/dom/Range.cpp#oldcode1507 third_party/WebKit/Source/core/dom/Range.cpp:1507: use_selection_height); Could you first remove ...
3 years, 7 months ago (2017-05-02 21:15:03 UTC) #9
tanvir
On 2017/05/02 21:15:03, Xiaocheng wrote: > Thanks for the patch. > > https://codereview.chromium.org/2854043002/diff/1/third_party/WebKit/Source/core/dom/Range.cpp > File ...
3 years, 7 months ago (2017-05-05 11:33:18 UTC) #10
Xiaocheng
+tkent lgtm with a nit https://codereview.chromium.org/2854043002/diff/20001/third_party/WebKit/Source/core/dom/Range.cpp File third_party/WebKit/Source/core/dom/Range.cpp (right): https://codereview.chromium.org/2854043002/diff/20001/third_party/WebKit/Source/core/dom/Range.cpp#newcode1483 third_party/WebKit/Source/core/dom/Range.cpp:1483: static Vector<IntRect> ComputeTextRects(const EphemeralRange& ...
3 years, 7 months ago (2017-05-05 17:14:28 UTC) #12
Xiaocheng
3 years, 7 months ago (2017-05-05 17:34:56 UTC) #14
tkent
https://codereview.chromium.org/2854043002/diff/20001/third_party/WebKit/Source/core/dom/Range.cpp File third_party/WebKit/Source/core/dom/Range.cpp (right): https://codereview.chromium.org/2854043002/diff/20001/third_party/WebKit/Source/core/dom/Range.cpp#newcode1487 third_party/WebKit/Source/core/dom/Range.cpp:1487: static Vector<FloatQuad> ComputeTextQuads(const EphemeralRange& range) { Why do we ...
3 years, 7 months ago (2017-05-07 22:55:12 UTC) #19
tanvir
PTAL!! Thanks https://codereview.chromium.org/2854043002/diff/20001/third_party/WebKit/Source/core/dom/Range.cpp File third_party/WebKit/Source/core/dom/Range.cpp (right): https://codereview.chromium.org/2854043002/diff/20001/third_party/WebKit/Source/core/dom/Range.cpp#newcode1487 third_party/WebKit/Source/core/dom/Range.cpp:1487: static Vector<FloatQuad> ComputeTextQuads(const EphemeralRange& range) { On ...
3 years, 7 months ago (2017-05-08 09:10:39 UTC) #21
yosin_UTC9
lgtm w/ nits https://codereview.chromium.org/2854043002/diff/20001/third_party/WebKit/Source/core/dom/Range.cpp File third_party/WebKit/Source/core/dom/Range.cpp (right): https://codereview.chromium.org/2854043002/diff/20001/third_party/WebKit/Source/core/dom/Range.cpp#newcode1487 third_party/WebKit/Source/core/dom/Range.cpp:1487: static Vector<FloatQuad> ComputeTextQuads(const EphemeralRange& range) { ...
3 years, 7 months ago (2017-05-08 09:14:19 UTC) #22
tkent
lgtm
3 years, 7 months ago (2017-05-08 14:34:02 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854043002/80001
3 years, 7 months ago (2017-05-09 12:12:05 UTC) #26
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 15:42:51 UTC) #29
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/f37555b2599b65017770d88c79ed...

Powered by Google App Engine
This is Rietveld 408576698