Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1181)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 285403004: Adds intrinsics for arm64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/intermediate_language_arm64.cc ('K') | « runtime/vm/intermediate_language_arm64.cc ('k') | runtime/vm/intrinsifier_arm.cc » ('j') | runtime/vm/intrinsifier_arm.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_x64.cc
===================================================================
--- runtime/vm/intermediate_language_x64.cc (revision 36300)
+++ runtime/vm/intermediate_language_x64.cc (working copy)
@@ -2594,6 +2594,8 @@
Register result) {
if (!range->IsWithin(-0x20000000000000LL, 0x20000000000000LL)) {
ASSERT(overflow != NULL);
+ // TODO(zra): This can be tightened to one compare/branch using:
+ // overflow = (result + 2^52) > 2^53.
regis 2014/05/19 20:14:02 the comparison must be unsigned
zra 2014/05/19 21:13:18 Amended TODO.
__ CompareImmediate(result, Immediate(-0x20000000000000LL), PP);
__ j(LESS, overflow);
__ CompareImmediate(result, Immediate(0x20000000000000LL), PP);
« runtime/vm/intermediate_language_arm64.cc ('K') | « runtime/vm/intermediate_language_arm64.cc ('k') | runtime/vm/intrinsifier_arm.cc » ('j') | runtime/vm/intrinsifier_arm.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698