Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1635)

Unified Diff: Source/modules/push_messaging/ServiceWorkerGlobalScopePush.idl

Issue 285403002: Push API: define push event on Service Worker. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase. Avoid modifying modules/serviceworkers/. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/push_messaging/ServiceWorkerGlobalScopePush.idl
diff --git a/Source/modules/push_messaging/NavigatorPushManager.idl b/Source/modules/push_messaging/ServiceWorkerGlobalScopePush.idl
similarity index 63%
copy from Source/modules/push_messaging/NavigatorPushManager.idl
copy to Source/modules/push_messaging/ServiceWorkerGlobalScopePush.idl
index 26db0dddc171d946dab70ea59e2202a465f47803..add41a8043850847a5f4c2a427b8b391afb668a7 100644
--- a/Source/modules/push_messaging/NavigatorPushManager.idl
+++ b/Source/modules/push_messaging/ServiceWorkerGlobalScopePush.idl
@@ -3,7 +3,8 @@
// found in the LICENSE file.
[
+ RuntimeEnabled=ServiceWorker,
dominicc (has gone to gerrit) 2014/05/22 06:52:28 Does this work? I thought you separated multiple v
Michael van Ouwerkerk 2014/05/23 18:32:03 Gating it on PushMessaging seems to be sufficient.
dominicc (has gone to gerrit) 2014/05/26 02:31:44 I agree that gating it on PushMessaging is fine; F
RuntimeEnabled=PushMessaging,
-] partial interface Navigator {
- readonly attribute PushManager push;
+] partial interface ServiceWorkerGlobalScope {
+ attribute EventHandler onpush;
};

Powered by Google App Engine
This is Rietveld 408576698