Source/modules/push_messaging/ServiceWorkerGlobalScopePush.idl - Issue 285403002: Push API: define push event on Service Worker.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/push_messaging/ServiceWorkerGlobalScopePush.idl

Issue 285403002: Push API: define push event on Service Worker. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase. Avoid modifying modules/serviceworkers/. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/push_messaging/PushEvent.idl ('K') | « Source/modules/push_messaging/ServiceWorkerGlobalScopePush.h ('k') | Source/web/ServiceWorkerGlobalScopeProxy.h » ('j') | Source/web/ServiceWorkerGlobalScopeProxy.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 [	5 [

	6 RuntimeEnabled=ServiceWorker,
	dominicc (has gone to gerrit) 2014/05/22 06:52:28 Does this work? I thought you separated multiple v Does this work? I thought you separated multiple values with \| but I can't find examples of either. Michael van Ouwerkerk 2014/05/23 18:32:03 Gating it on PushMessaging seems to be sufficient. Show quoted text On 2014/05/22 06:52:28, dominicc wrote: > Does this work? I thought you separated multiple values with \| but I can't find > examples of either. Gating it on PushMessaging seems to be sufficient. dominicc (has gone to gerrit) 2014/05/26 02:31:44 I agree that gating it on PushMessaging is fine; F Show quoted text On 2014/05/23 18:32:03, Michael van Ouwerkerk wrote: > On 2014/05/22 06:52:28, dominicc wrote: > > Does this work? I thought you separated multiple values with \| but I can't > find > > examples of either. > > Gating it on PushMessaging seems to be sufficient. I agree that gating it on PushMessaging is fine; FWIW I chatted with nbarth and the synax is X=A\|B You should add a virtual/webexposed test for this if you didn't already.
6 RuntimeEnabled=PushMessaging,	7 RuntimeEnabled=PushMessaging,

7 ] partial interface Navigator {	8 ] partial interface ServiceWorkerGlobalScope {

8 readonly attribute PushManager push;	9 attribute EventHandler onpush;

9 };	10 };

OLD	NEW