Make JavaScriptBackend.processAnnotations element-model agnostic

Make JavaScriptBackend.processAnnotations element-model agnostic

R=sigmund@google.com, sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/859bb784eda9ab35b0ce9004adb5d5117544b288

Reverted: https://github.com/dart-lang/sdk/commit/457c277f6f0aa719b7be94cbe6fedf7a749b56e0
Committed: https://github.com/dart-lang/sdk/commit/cace0b556d1d3ea6d2494039ba7ed2b56836b226

[Johnni Winther, 2017-05-02 08:56:13]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-05-02 20:04:23]

lgtm, nice

https://codereview.chromium.org/2854013002/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/inferrer_engine.dart (right):

https://codereview.chromium.org/2854013002/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/inferrer_engine.dart:90: return element is
MemberElement && annotations.assumeDynamic(element);
nit: let's rename annotations too (optimizerHints?)

https://codereview.chromium.org/2854013002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/2854013002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/backend.dart:481: annotations = new
OptimizerHintsForTests(
ditto

https://codereview.chromium.org/2854013002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map.dart (right):

https://codereview.chromium.org/2854013002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map.dart:823: _metadata =
elementMap.getMetadata(node.annotations);
nit: replace with ??=

[Johnni Winther, 2017-05-03 08:05:59]

https://codereview.chromium.org/2854013002/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/inferrer_engine.dart (right):

https://codereview.chromium.org/2854013002/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/inferrer_engine.dart:90: return element is
MemberElement && annotations.assumeDynamic(element);
On 2017/05/02 20:04:22, Siggi Cherem (dart-lang) wrote:
> nit: let's rename annotations too (optimizerHints?)

Done.

https://codereview.chromium.org/2854013002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/2854013002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/backend.dart:481: annotations = new
OptimizerHintsForTests(
On 2017/05/02 20:04:22, Siggi Cherem (dart-lang) wrote:
> ditto

Done.

https://codereview.chromium.org/2854013002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map.dart (right):

https://codereview.chromium.org/2854013002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map.dart:823: _metadata =
elementMap.getMetadata(node.annotations);
On 2017/05/02 20:04:22, Siggi Cherem (dart-lang) wrote:
> nit: replace with ??=

Done.

[Johnni Winther, 2017-05-03 08:14:09]

Description was changed from

==========
Make JavaScriptBackend.processAnnotations element-model agnostic
==========

to

==========
Make JavaScriptBackend.processAnnotations element-model agnostic

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/859bb784eda9ab35b0ce9004adb5d5117544b288
==========

[Johnni Winther, 2017-05-03 08:14:11]

Committed patchset #2 (id:20001) manually as
859bb784eda9ab35b0ce9004adb5d5117544b288 (presubmit successful).

[Johnni Winther, 2017-05-04 07:40:19]

Description was changed from

==========
Make JavaScriptBackend.processAnnotations element-model agnostic

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/859bb784eda9ab35b0ce9004adb5d5117544b288
==========

to

==========
Make JavaScriptBackend.processAnnotations element-model agnostic

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/859bb784eda9ab35b0ce9004adb5d5117544b288

Reverted:
https://github.com/dart-lang/sdk/commit/457c277f6f0aa719b7be94cbe6fedf7a749b56e0
==========

[Johnni Winther, 2017-05-04 07:53:45]

PTAL @ the last patch

[Siggi Cherem (dart-lang), 2017-05-04 18:30:30]

lgtm

+sra - so you can see the fix

[sra1, 2017-05-04 19:06:40]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2017-05-04 19:06:40]

lgtm

[Johnni Winther, 2017-05-05 07:43:09]

Description was changed from

==========
Make JavaScriptBackend.processAnnotations element-model agnostic

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/859bb784eda9ab35b0ce9004adb5d5117544b288

Reverted:
https://github.com/dart-lang/sdk/commit/457c277f6f0aa719b7be94cbe6fedf7a749b56e0
==========

to

==========
Make JavaScriptBackend.processAnnotations element-model agnostic

R=sigmund@google.com, sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/859bb784eda9ab35b0ce9004adb5d5117544b288

Reverted:
https://github.com/dart-lang/sdk/commit/457c277f6f0aa719b7be94cbe6fedf7a749b56e0
Committed:
https://github.com/dart-lang/sdk/commit/cace0b556d1d3ea6d2494039ba7ed2b56836b226
==========

[Johnni Winther, 2017-05-05 07:43:11]

Committed patchset #4 (id:60001) manually as
cace0b556d1d3ea6d2494039ba7ed2b56836b226 (presubmit successful).