Make JavaScriptBackend.processAnnotations element-model agnostic

pkg/compiler/lib/src/js_backend/backend.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library js_backend.backend;
 
 import '../common.dart';
 import '../common/backend_api.dart'
     show ForeignResolver, NativeRegistry, ImpactTransformer;
 import '../common/codegen.dart' show CodegenImpact, CodegenWorkItem;
@@ skipping 94 matching lines @@
   static const int _canInlineInLoopMustNotOutside = 2;
   // May-inline means that we know that it can be inlined inside a loop, but
   // don't know about the general case yet.
   static const int _canInlineInLoopMayInlineOutside = 3;
   static const int _canInline = 4;
   static const int _mustInline = 5;
 
   final Map<FunctionEntity, int> _cachedDecisions =
       new Map<FunctionEntity, int>();
 
+  /// Checks that [method] is the canonical representative for this method.
+  ///
+  /// For a [MethodElement] this means it must be the declaration element.
+  bool checkFunction(FunctionEntity method) {
+    if (method is MethodElement) return method.isDeclaration;
+    return true;
+  }
+
   /// Returns the current cache decision. This should only be used for testing.
-  int getCurrentCacheDecisionForTesting(Element element) {
+  int getCurrentCacheDecisionForTesting(FunctionEntity element) {
+    assert(checkFunction(element));
     return _cachedDecisions[element];
   }
 
   // Returns `true`/`false` if we have a cached decision.
   // Returns `null` otherwise.
   bool canInline(FunctionEntity element, {bool insideLoop}) {
+    assert(checkFunction(element));
     int decision = _cachedDecisions[element];
 
     if (decision == null) {
       // These synthetic elements are not yet present when we initially compute
       // this cache from metadata annotations, so look for their parent.
       if (element is ConstructorBodyElement) {
         ConstructorBodyElement body = element;
         decision = _cachedDecisions[body.constructor];
       }
       if (decision == null) {
@@ skipping 35 matching lines @@
         case _mustInline:
           return true;
       }
     }
 
     // Quiet static checker.
     return null;
   }
 
   void markAsInlinable(FunctionEntity element, {bool insideLoop}) {
+    assert(checkFunction(element));
     int oldDecision = _cachedDecisions[element];
 
     if (oldDecision == null) {
       oldDecision = _unknown;
     }
 
     if (insideLoop) {
       switch (oldDecision) {
         case _mustNotInline:
           throw new SpannableAssertionFailure(
@@ skipping 35 matching lines @@
 
         case _canInline:
         case _mustInline:
           // Do nothing.
           break;
       }
     }
   }
 
   void markAsNonInlinable(FunctionEntity element, {bool insideLoop: true}) {
+    assert(checkFunction(element));
     int oldDecision = _cachedDecisions[element];
 
     if (oldDecision == null) {
       oldDecision = _unknown;
     }
 
     if (insideLoop) {
       switch (oldDecision) {
         case _canInlineInLoopMustNotOutside:
         case _canInlineInLoopMayInlineOutside:
@@ skipping 38 matching lines @@
         case _mayInlineInLoopMustNotOutside:
         case _canInlineInLoopMustNotOutside:
         case _mustNotInline:
           // Do nothing.
           break;
       }
     }
   }
 
   void markAsMustInline(FunctionEntity element) {
+    assert(checkFunction(element));
     _cachedDecisions[element] = _mustInline;
   }
 }
 
 enum SyntheticConstantKind {
   DUMMY_INTERCEPTOR,
   EMPTY_VALUE,
   TYPEVARIABLE_REFERENCE, // Reference to a type in reflection data.
   NAME
 }
 
 class JavaScriptBackend {
   static const String JS = 'JS';
   static const String JS_BUILTIN = 'JS_BUILTIN';
   static const String JS_EMBEDDED_GLOBAL = 'JS_EMBEDDED_GLOBAL';
   static const String JS_INTERCEPTOR_CONSTANT = 'JS_INTERCEPTOR_CONSTANT';
 
   final Compiler compiler;
 
   /// Returns true if the backend supports reflection.
   bool get supportsReflection => emitter.supportsReflection;
 
-  final OptimizerHintsForTests annotations;
+  final OptimizerHintsForTests optimizerHints;
 
   /// Set of classes that need to be considered for reflection although not
   /// otherwise visible during resolution.
   Iterable<ClassEntity> get classesRequiredForReflection {
     // TODO(herhut): Clean this up when classes needed for rti are tracked.
     return [commonElements.closureClass, commonElements.jsIndexableClass];
   }
 
   FunctionCompiler functionCompiler;
 
@@ skipping 147 matching lines @@
     }
   }
 
   JavaScriptBackend(this.compiler,
       {bool generateSourceMap: true,
       bool useStartupEmitter: false,
       bool useMultiSourceInfo: false,
       bool useNewSourceInfo: false,
       bool useKernel: false})
       : _rti = new _RuntimeTypes(compiler),
-        annotations = new OptimizerHintsForTests(compiler),
+        optimizerHints = new OptimizerHintsForTests(
+            compiler.elementEnvironment, compiler.commonElements),
         this.sourceInformationStrategy = createSourceInformationStrategy(
             generateSourceMap: generateSourceMap,
             useMultiSourceInfo: useMultiSourceInfo,
             useNewSourceInfo: useNewSourceInfo),
         constantCompilerTask = new JavaScriptConstantTask(compiler),
         _nativeDataResolver = new NativeDataResolverImpl(compiler),
         _rtiNeedBuilder =
             compiler.frontEndStrategy.createRuntimeTypesNeedBuilder() {
     _target = new JavaScriptBackendTarget(this);
     impacts = new BackendImpacts(compiler.options, commonElements);
@@ skipping 680 matching lines @@
   bool isTargetSpecificLibrary(LibraryElement library) {
     Uri canonicalUri = library.canonicalUri;
     if (canonicalUri == Uris.dart__js_helper ||
         canonicalUri == Uris.dart__interceptors) {
       return true;
     }
     return false;
   }
 
   /// Process backend specific annotations.
+  // TODO(johnniwinther): Merge this with [AnnotationProcessor] and use
+  // [ElementEnvironment.getMemberMetadata] in [AnnotationProcessor].
   void processAnnotations(
-      MemberElement element, ClosedWorldRefiner closedWorldRefiner) {
-    if (element.isMalformed) {
+      MemberEntity element, ClosedWorldRefiner closedWorldRefiner) {
+    if (element is MemberElement && element.isMalformed) {
       // Elements that are marked as malformed during parsing or resolution
       // might be registered here. These should just be ignored.
       return;
     }
 
     if (element.isFunction || element.isConstructor) {
-      MethodElement method = element.implementation;
-      if (annotations.noInline(method)) {
-        inlineCache.markAsNonInlinable(method);
+      if (optimizerHints.noInline(element)) {
+        inlineCache.markAsNonInlinable(element);
       }
     }
     if (element.isField) return;
-    MethodElement method = element;
+    FunctionEntity method = element;
 
-    LibraryElement library = method.library;
-    if (!library.isPlatformLibrary && !canLibraryUseNative(library)) return;
+    LibraryEntity library = method.library;
+    if (library.canonicalUri.scheme != 'dart' &&
+        !canLibraryUseNative(library)) {
+      return;
+    }
     bool hasNoInline = false;
     bool hasForceInline = false;
     bool hasNoThrows = false;
     bool hasNoSideEffects = false;
-    for (MetadataAnnotation metadata in method.implementation.metadata) {
-      metadata.ensureResolved(resolution);
-      ConstantValue constantValue =
-          compiler.constants.getConstantValue(metadata.constant);
+    for (ConstantValue constantValue
+        in compiler.elementEnvironment.getMemberMetadata(method)) {
       if (!constantValue.isConstructedObject) continue;
       ObjectConstantValue value = constantValue;
-      ClassElement cls = value.type.element;
+      ClassEntity cls = value.type.element;
       if (cls == commonElements.forceInlineClass) {
         hasForceInline = true;
         if (VERBOSE_OPTIMIZER_HINTS) {
           reporter.reportHintMessage(
               method, MessageKind.GENERIC, {'text': "Must inline"});
         }
         inlineCache.markAsMustInline(method);
       } else if (cls == commonElements.noInlineClass) {
         hasNoInline = true;
         if (VERBOSE_OPTIMIZER_HINTS) {
           reporter.reportHintMessage(
               method, MessageKind.GENERIC, {'text': "Cannot inline"});
         }
         inlineCache.markAsNonInlinable(method);
       } else if (cls == commonElements.noThrowsClass) {
         hasNoThrows = true;
-        if (!Elements.isStaticOrTopLevelFunction(method) &&
-            !method.isFactoryConstructor) {
+        bool isValid = true;
+        if (method.isTopLevel) {
+          isValid = true;
+        } else if (method.isStatic) {
+          isValid = true;
+        } else if (method is ConstructorEntity && method.isFactoryConstructor) {
+          isValid = true;
+        }
+        if (!isValid) {
           reporter.internalError(
               method,
               "@NoThrows() is currently limited to top-level"
               " or static functions and factory constructors.");
         }
         if (VERBOSE_OPTIMIZER_HINTS) {
           reporter.reportHintMessage(
               method, MessageKind.GENERIC, {'text': "Cannot throw"});
         }
         closedWorldRefiner.registerCannotThrow(method);
@@ skipping 212 matching lines @@
 
   bool canUseAliasedSuperMember(MemberEntity member, Selector selector) {
     return !selector.isGetter;
   }
 
   /// Returns `true` if [member] is called from a subclass via `super`.
   bool isAliasedSuperMember(MemberEntity member) {
     return _aliasedSuperMembers.contains(member);
   }
 }