Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2853963002: Add team and component information for ChromeOS printing code. (Closed)

Created:
3 years, 7 months ago by skau
Modified:
3 years, 7 months ago
Reviewers:
ymzhang1, xdai1
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org, adlr, Carlson
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add team and component information for ChromeOS printing code. The proposal includes a request for a public (chromium.org) discussion group, so I've started cros-printing-dev@chromium.org. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping BUG=679905 Review-Url: https://codereview.chromium.org/2853963002 Cr-Commit-Position: refs/heads/master@{#469098} Committed: https://chromium.googlesource.com/chromium/src/+/7d5f251bf9039c1c0ca1581f536c5593f4a562da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/chromeos/printing/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M chromeos/printing/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
skau
3 years, 7 months ago (2017-05-02 03:05:25 UTC) #2
xdai1
lgtm
3 years, 7 months ago (2017-05-02 16:23:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853963002/1
3 years, 7 months ago (2017-05-03 19:54:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/7d5f251bf9039c1c0ca1581f536c5593f4a562da
3 years, 7 months ago (2017-05-03 20:08:24 UTC) #8
ymzhang1
3 years, 7 months ago (2017-05-05 02:35:48 UTC) #9
Message was sent while issue was closed.
On 2017/05/03 20:08:24, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/7d5f251bf9039c1c0ca1581f536c...

lgtm

Powered by Google App Engine
This is Rietveld 408576698