Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2853943002: Make sure progress bar is attached before init (Closed)

Created:
3 years, 7 months ago by mdjones
Modified:
3 years, 7 months ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure progress bar is attached before init This change makes sure that the progress bar has been attached to the hierarchy before trying to initialize it. Many of the null checks have also been removed since the progress bar is now created in the constructor. BUG=716382 Review-Url: https://codereview.chromium.org/2853943002 Cr-Commit-Position: refs/heads/master@{#468532} Committed: https://chromium.googlesource.com/chromium/src/+/2efffa89a050e8d0c3c6829f7bd63eb3970f0eaa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -15 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java View 6 chunks +14 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
mdjones
plz
3 years, 7 months ago (2017-05-02 01:10:16 UTC) #3
gone
lgtm
3 years, 7 months ago (2017-05-02 01:13:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853943002/1
3 years, 7 months ago (2017-05-02 01:13:44 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 02:01:16 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2efffa89a050e8d0c3c6829f7bd6...

Powered by Google App Engine
This is Rietveld 408576698