Fixes use-of-uninitialized-value MSan error in image_skia_unittest

Fixes use-of-uninitialized-value MSan error in image_skia_unittest

The existing test code returns an empty ImageSkiaRep where
bytes are allocated but nothing is initialized. This was okay
because ImageSkiaTest doesn't touch the contents of the image.

Now ImageSkia can rescale the image data and such cases are
tested. So using a dummy ImageSkiaRep wouldn't be helthy.
Rather some data should be drawn.

BUG=373748
R=oshima@chromium.org
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270970

[Jun Mukai, 2014-05-15 15:59:53]

I believe this patch fixes the issue (are there any trybots to verify?)

[oshima, 2014-05-15 16:14:13]

https://codereview.chromium.org/285393002/diff/1/ui/gfx/image/image_skia_unit...
File ui/gfx/image/image_skia_unittest.cc (left):

https://codereview.chromium.org/285393002/diff/1/ui/gfx/image/image_skia_unit...
ui/gfx/image/image_skia_unittest.cc:57: return gfx::ImageSkiaRep(size_, scale);
this constructor is used in other tests (and only in tests) and they expects the
content is valid (because ImageSkiaRep::bitmap() is const), so probably better
to fix it in the constructor.

You can just call

bitmap_.eraseColor(<color>);

there

[earthdok, 2014-05-15 16:18:18]

On 2014/05/15 15:59:53, Jun Mukai wrote:
> I believe this patch fixes the issue (are there any trybots to verify?)

There aren't any. I've verified the fix locally.

[Jun Mukai, 2014-05-16 01:57:33]

https://codereview.chromium.org/285393002/diff/1/ui/gfx/image/image_skia_unit...
File ui/gfx/image/image_skia_unittest.cc (left):

https://codereview.chromium.org/285393002/diff/1/ui/gfx/image/image_skia_unit...
ui/gfx/image/image_skia_unittest.cc:57: return gfx::ImageSkiaRep(size_, scale);
On 2014/05/15 16:14:13, oshima wrote:
> this constructor is used in other tests (and only in tests) and they expects
the
> content is valid (because ImageSkiaRep::bitmap() is const), so probably better
> to fix it in the constructor.
> 
> You can just call
> 
> bitmap_.eraseColor(<color>);
> 
> there

Done.

[oshima, 2014-05-16 03:23:39]

lgtm

[Jun Mukai, 2014-05-16 04:18:37]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-05-16 04:19:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/285393002/20001

[commit-bot: I haz the power, 2014-05-16 06:06:22]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-16 06:59:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-16 06:59:30]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[Jun Mukai, 2014-05-16 07:11:16]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-05-16 07:11:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/285393002/20001

[commit-bot: I haz the power, 2014-05-16 08:06:28]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-16 09:11:08]

Change committed as 270970