Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: ui/gfx/image/image_skia_rep.h

Issue 285393002: Fixes use-of-uninitialized-value MSan error in image_skia_unittest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | ui/gfx/image/image_skia_rep.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_GFX_IMAGE_IMAGE_SKIA_REP_H_ 5 #ifndef UI_GFX_IMAGE_IMAGE_SKIA_REP_H_
6 #define UI_GFX_IMAGE_IMAGE_SKIA_REP_H_ 6 #define UI_GFX_IMAGE_IMAGE_SKIA_REP_H_
7 7
8 #include "third_party/skia/include/core/SkBitmap.h" 8 #include "third_party/skia/include/core/SkBitmap.h"
9 #include "ui/gfx/gfx_export.h" 9 #include "ui/gfx/gfx_export.h"
10 #include "ui/gfx/size.h" 10 #include "ui/gfx/size.h"
11 11
12 namespace gfx { 12 namespace gfx {
13 13
14 // An ImageSkiaRep represents a bitmap and the scale factor it is intended for. 14 // An ImageSkiaRep represents a bitmap and the scale factor it is intended for.
15 // 0.0f scale is used to indicate that this ImageSkiaRep is used for unscaled 15 // 0.0f scale is used to indicate that this ImageSkiaRep is used for unscaled
16 // image (the image that only returns 1.0f scale image). 16 // image (the image that only returns 1.0f scale image).
17 class GFX_EXPORT ImageSkiaRep { 17 class GFX_EXPORT ImageSkiaRep {
18 public: 18 public:
19 // Create null bitmap. 19 // Create null bitmap.
20 ImageSkiaRep(); 20 ImageSkiaRep();
21 ~ImageSkiaRep(); 21 ~ImageSkiaRep();
22 22
23 // Creates a bitmap with kARGB_8888_Config config with given |size| in DIP. 23 // Creates a bitmap with kARGB_8888_Config config with given |size| in DIP.
24 // This allocates pixels in the bitmap. Specifying 0 scale means the image 24 // This allocates pixels in the bitmap and fill the bitmap with a color.
25 // is for unscaled image. (unscaled() returns truen, and scale() returns 25 // Specifying 0 scale means the image is for unscaled image. (unscaled()
26 // 1.0f;) 26 // returns truen, and scale() returns 1.0f;)
27 ImageSkiaRep(const gfx::Size& size, float scale); 27 ImageSkiaRep(const gfx::Size& size, float scale);
28 28
29 // Creates a bitmap with given scale. 29 // Creates a bitmap with given scale.
30 // Adds ref to |src|. 30 // Adds ref to |src|.
31 ImageSkiaRep(const SkBitmap& src, float scale); 31 ImageSkiaRep(const SkBitmap& src, float scale);
32 32
33 // Returns true if the backing bitmap is null. 33 // Returns true if the backing bitmap is null.
34 bool is_null() const { return bitmap_.isNull(); } 34 bool is_null() const { return bitmap_.isNull(); }
35 35
36 // Get width and height of bitmap in DIP. 36 // Get width and height of bitmap in DIP.
(...skipping 23 matching lines...) Expand all
60 SkBitmap& mutable_sk_bitmap() { return bitmap_; } 60 SkBitmap& mutable_sk_bitmap() { return bitmap_; }
61 61
62 SkBitmap bitmap_; 62 SkBitmap bitmap_;
63 63
64 float scale_; 64 float scale_;
65 }; 65 };
66 66
67 } // namespace gfx 67 } // namespace gfx
68 68
69 #endif // UI_GFX_IMAGE_IMAGE_SKIA_REP_H_ 69 #endif // UI_GFX_IMAGE_IMAGE_SKIA_REP_H_
OLDNEW
« no previous file with comments | « no previous file | ui/gfx/image/image_skia_rep.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698