Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 2853913002: Fix crash when AccessibilityManager called when profile is nullptr (Closed)

Created:
3 years, 7 months ago by dmazzoni
Modified:
3 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash when AccessibilityManager called when profile is nullptr BUG=717263 Review-Url: https://codereview.chromium.org/2853913002 Cr-Commit-Position: refs/heads/master@{#468546} Committed: https://chromium.googlesource.com/chromium/src/+/c613a5600d8bf1d7ca3f14d088cceecdfcc99ca3

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 2 chunks +6 lines, -0 lines 1 comment Download

Messages

Total messages: 13 (8 generated)
dmazzoni
3 years, 7 months ago (2017-05-01 22:16:42 UTC) #3
oshima
lgtm https://codereview.chromium.org/2853913002/diff/1/chrome/browser/chromeos/accessibility/accessibility_manager.cc File chrome/browser/chromeos/accessibility/accessibility_manager.cc (right): https://codereview.chromium.org/2853913002/diff/1/chrome/browser/chromeos/accessibility/accessibility_manager.cc#newcode601 chrome/browser/chromeos/accessibility/accessibility_manager.cc:601: if (!profile()) optional: just noticed that all other ...
3 years, 7 months ago (2017-05-02 01:45:20 UTC) #7
dmazzoni
On 2017/05/02 01:45:20, oshima wrote: > lgtm > > https://codereview.chromium.org/2853913002/diff/1/chrome/browser/chromeos/accessibility/accessibility_manager.cc > File chrome/browser/chromeos/accessibility/accessibility_manager.cc (right): > ...
3 years, 7 months ago (2017-05-02 03:14:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853913002/1
3 years, 7 months ago (2017-05-02 03:15:11 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 03:19:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c613a5600d8bf1d7ca3f14d088cc...

Powered by Google App Engine
This is Rietveld 408576698