Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2853903002: Handle the case where the update check for components fails. (Closed)

Created:
3 years, 7 months ago by Sorin Jianu
Modified:
3 years, 7 months ago
Reviewers:
waffles
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle the case where the update check for components fails. Before the change, an update check error would terminate the update but leave the components unhandled. Therefore, for an external observer, it would appear that the components were stuck on checking for updates. BUG=687231 Review-Url: https://codereview.chromium.org/2853903002 Cr-Commit-Position: refs/heads/master@{#468475} Committed: https://chromium.googlesource.com/chromium/src/+/03ec5b7ac64e08b079a550314ab78443d4c5a59e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -9 lines) Patch
M components/update_client/update_client_unittest.cc View 1 chunk +104 lines, -0 lines 0 comments Download
M components/update_client/update_engine.cc View 2 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Sorin Jianu
PTAL! Thank you!
3 years, 7 months ago (2017-05-01 22:17:07 UTC) #4
waffles
lgtm
3 years, 7 months ago (2017-05-01 22:56:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853903002/1
3 years, 7 months ago (2017-05-01 23:09:35 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 23:14:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/03ec5b7ac64e08b079a550314ab7...

Powered by Google App Engine
This is Rietveld 408576698