Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Unified Diff: base/metrics/sample_map_unittest.cc

Issue 2853853002: Fix overflow when logging MaxInt32 to a sparse histogram. (Closed)
Patch Set: Address comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/sample_map.cc ('k') | base/metrics/sample_vector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/sample_map_unittest.cc
diff --git a/base/metrics/sample_map_unittest.cc b/base/metrics/sample_map_unittest.cc
index 91a9dcf40f83d61506cf7c50b7246c48df9373ee..6e6da2b3d24cdb8220fa32c16b92cc1470a37f65 100644
--- a/base/metrics/sample_map_unittest.cc
+++ b/base/metrics/sample_map_unittest.cc
@@ -81,7 +81,7 @@ TEST(SampleMapIteratorTest, IterateTest) {
std::unique_ptr<SampleCountIterator> it = samples.Iterator();
HistogramBase::Sample min;
- HistogramBase::Sample max;
+ int64_t max;
HistogramBase::Count count;
it->Get(&min, &max, &count);
@@ -125,7 +125,7 @@ TEST(SampleMapIteratorTest, SkipEmptyRanges) {
EXPECT_FALSE(it->Done());
HistogramBase::Sample min;
- HistogramBase::Sample max;
+ int64_t max;
HistogramBase::Count count;
it->Get(&min, &max, &count);
@@ -153,7 +153,7 @@ TEST(SampleMapIteratorDeathTest, IterateDoneTest) {
EXPECT_TRUE(it->Done());
HistogramBase::Sample min;
- HistogramBase::Sample max;
+ int64_t max;
HistogramBase::Count count;
EXPECT_DCHECK_DEATH(it->Get(&min, &max, &count));
« no previous file with comments | « base/metrics/sample_map.cc ('k') | base/metrics/sample_vector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698