base/metrics/sample_vector.h - Issue 2853853002: Fix overflow when logging MaxInt32 to a sparse histogram.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/sample_vector.h

Issue 2853853002: Fix overflow when logging MaxInt32 to a sparse histogram. (Closed)

Patch Set: Address comments. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/sample_vector.h

diff --git a/base/metrics/sample_vector.h b/base/metrics/sample_vector.h

index a264b7e7d44684629c71635be39e4f5f9b2843c9..8e28e29165029aeecd200c64fb83adeb64c35f62 100644

--- a/base/metrics/sample_vector.h

+++ b/base/metrics/sample_vector.h

@@ -162,7 +162,7 @@ class BASE_EXPORT SampleVectorIterator : public SampleCountIterator {

bool Done() const override;

void Next() override;

void Get(HistogramBase::Sample* min,

- HistogramBase::Sample* max,

+ int64_t* max,

HistogramBase::Count* count) const override;

// SampleVector uses predefined buckets, so iterator can return bucket index.

« no previous file with comments | « base/metrics/sample_map_unittest.cc ('k') | base/metrics/sample_vector.cc » ('j') | no next file with comments »