Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2853843002: Fix controller positioning in VrShell when gyro reads are small (Closed)

Created:
3 years, 7 months ago by acondor_
Modified:
3 years, 7 months ago
Reviewers:
mthiesse
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix controller positioning in VrShell when gyro reads are small BUG=716201 Review-Url: https://codereview.chromium.org/2853843002 Cr-Commit-Position: refs/heads/master@{#468375} Committed: https://chromium.googlesource.com/chromium/src/+/f00f17c2badfd4132e5cac30413804ce34f72cbe

Patch Set 1 #

Patch Set 2 : Dchecking not null quat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/android/vr_shell/elbow_model.cc View 1 chunk +1 line, -3 lines 0 comments Download
M device/vr/vr_math.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
acondor_
PTAL
3 years, 7 months ago (2017-05-01 17:39:16 UTC) #2
mthiesse
Can you please also add a DCHECK to vr::NormalizeQuat, and have it not return NaN ...
3 years, 7 months ago (2017-05-01 17:47:31 UTC) #3
acondor_
On 2017/05/01 17:47:31, mthiesse wrote: > Can you please also add a DCHECK to vr::NormalizeQuat, ...
3 years, 7 months ago (2017-05-01 17:49:43 UTC) #4
mthiesse
lgtm
3 years, 7 months ago (2017-05-01 17:50:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853843002/20001
3 years, 7 months ago (2017-05-01 17:51:53 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 18:56:46 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f00f17c2badfd4132e5cac304138...

Powered by Google App Engine
This is Rietveld 408576698