Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2853833002: Add some missing Skia includes (Closed)

Created:
3 years, 7 months ago by f(malita)
Modified:
3 years, 7 months ago
Reviewers:
mtklein_C, reed1
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, darin-cc_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, jam, Justin Novosad, kinuko+watch, mlamouri+watch-content_chromium.org, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add some missing Skia includes SkCanvas.h will no longer pull SkBitmap.h and SkImage.h: https://skia-review.googlesource.com/c/14904. Include these explicitly, where needed. TBR= Review-Url: https://codereview.chromium.org/2853833002 Cr-Commit-Position: refs/heads/master@{#468387} Committed: https://chromium.googlesource.com/chromium/src/+/97c251f3ce40cf8658790430b87301c3ea57181c

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove unneeded fwdecl, include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/renderer/pepper/ppb_image_data_impl.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M skia/ext/benchmarking_canvas.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/InterceptingCanvas.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
f(malita)
3 years, 7 months ago (2017-05-01 17:11:07 UTC) #4
mtklein_C
lgtm
3 years, 7 months ago (2017-05-01 17:17:03 UTC) #5
mtklein_C
https://codereview.chromium.org/2853833002/diff/1/content/renderer/pepper/ppb_image_data_impl.h File content/renderer/pepper/ppb_image_data_impl.h (right): https://codereview.chromium.org/2853833002/diff/1/content/renderer/pepper/ppb_image_data_impl.h#newcode22 content/renderer/pepper/ppb_image_data_impl.h:22: class SkBitmap; Can probably kill this line off?
3 years, 7 months ago (2017-05-01 17:17:46 UTC) #6
f(malita)
https://codereview.chromium.org/2853833002/diff/1/content/renderer/pepper/ppb_image_data_impl.h File content/renderer/pepper/ppb_image_data_impl.h (right): https://codereview.chromium.org/2853833002/diff/1/content/renderer/pepper/ppb_image_data_impl.h#newcode22 content/renderer/pepper/ppb_image_data_impl.h:22: class SkBitmap; On 2017/05/01 17:17:46, mtklein_C wrote: > Can ...
3 years, 7 months ago (2017-05-01 17:22:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853833002/20001
3 years, 7 months ago (2017-05-01 17:31:20 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 19:35:10 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/97c251f3ce40cf8658790430b873...

Powered by Google App Engine
This is Rietveld 408576698