Retrieve pinned flag directly from Notification class

Retrieve pinned flag directly from Notification class

This CL removes the IsPinned getter method from CustomNotificationContentViewDelegate. The flag "pinned" can be retrieved directly from Notification class, and doesn't need to use delegate.

This is refactoring CL and shouldn't change any behavior.

BUG=717455
TEST=manual

Review-Url: https://codereview.chromium.org/2853783004
Cr-Commit-Position: refs/heads/master@{#469915}
Committed: https://chromium.googlesource.com/chromium/src/+/25d817a0ebe1e8c830e56cc20adedb9fd7b7deeb

[yoshiki, 2017-05-02 07:57:24]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 07:57:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 08:40:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 08:40:37]

Dry run: This issue passed the CQ dry run.

[yoshiki, 2017-05-02 08:50:52]

Description was changed from

==========
wip

.


.

BUG=
==========

to

==========
Remove IsPinned getter from CustomNotificationContentViewDelegate

This flag can be retrieved directly from Notification class.

BUG=
==========

[yoshiki, 2017-05-02 09:11:16]

Description was changed from

==========
Remove IsPinned getter from CustomNotificationContentViewDelegate

This flag can be retrieved directly from Notification class.

BUG=
==========

to

==========
Remove IsPinned getter from CustomNotificationContentViewDelegate

This flag can be retrieved directly from Notification class.

BUG=717455
==========

[yoshiki, 2017-05-02 09:54:48]

Description was changed from

==========
Remove IsPinned getter from CustomNotificationContentViewDelegate

This flag can be retrieved directly from Notification class.

BUG=717455
==========

to

==========
Remove IsPinned getter from CustomNotificationContentViewDelegate

This flag can be retrieved directly from Notification class, and doesn't need to
use delegate.

BUG=717455
==========

[yoshiki, 2017-05-02 09:54:48]

yoshiki@chromium.org changed reviewers:
+ yhanada@chromium.org

[yoshiki, 2017-05-02 09:56:13]

Description was changed from

==========
Remove IsPinned getter from CustomNotificationContentViewDelegate

This flag can be retrieved directly from Notification class, and doesn't need to
use delegate.

BUG=717455
==========

to

==========
Retrieve pinned flag directly from Notification class

This CL removes the IsPinned getter method from
CustomNotificationContentViewDelegate. The flag "pinned" can be retrieved
directly from Notification class, and doesn't need to use delegate.

BUG=717455
TEST=manual
==========

[yoshiki, 2017-05-02 09:56:36]

Description was changed from

==========
Retrieve pinned flag directly from Notification class

This CL removes the IsPinned getter method from
CustomNotificationContentViewDelegate. The flag "pinned" can be retrieved
directly from Notification class, and doesn't need to use delegate.

BUG=717455
TEST=manual
==========

to

==========
Retrieve pinned flag directly from Notification class

This CL removes the IsPinned getter method from
CustomNotificationContentViewDelegate. The flag "pinned" can be retrieved
directly from Notification class, and doesn't need to use delegate.

This is refactoring CL and shouldn't change any behavior.

BUG=717455
TEST=manual
==========

[yoshiki, 2017-05-02 09:56:44]

Hanada-san, PTAL. Thanks

[yhanada, 2017-05-08 02:29:03]

lgtm!

[yoshiki, 2017-05-08 03:24:33]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2017-05-08 03:24:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 04:39:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 04:39:24]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yoshiki, 2017-05-08 04:43:52]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2017-05-08 04:44:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 06:02:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 06:02:32]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yoshiki, 2017-05-08 06:07:46]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2017-05-08 06:08:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 07:44:51]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494223666784760, "parent_rev":
"0657b42372a48280879bb16061dcbd258a360814", "commit_rev":
"25d817a0ebe1e8c830e56cc20adedb9fd7b7deeb"}

[commit-bot: I haz the power, 2017-05-08 07:45:27]

Description was changed from

==========
Retrieve pinned flag directly from Notification class

This CL removes the IsPinned getter method from
CustomNotificationContentViewDelegate. The flag "pinned" can be retrieved
directly from Notification class, and doesn't need to use delegate.

This is refactoring CL and shouldn't change any behavior.

BUG=717455
TEST=manual
==========

to

==========
Retrieve pinned flag directly from Notification class

This CL removes the IsPinned getter method from
CustomNotificationContentViewDelegate. The flag "pinned" can be retrieved
directly from Notification class, and doesn't need to use delegate.

This is refactoring CL and shouldn't change any behavior.

BUG=717455
TEST=manual

Review-Url: https://codereview.chromium.org/2853783004
Cr-Commit-Position: refs/heads/master@{#469915}
Committed:
https://chromium.googlesource.com/chromium/src/+/25d817a0ebe1e8c830e56cc20ade...
==========

[commit-bot: I haz the power, 2017-05-08 07:45:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/25d817a0ebe1e8c830e56cc20ade...