Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2853763003: MD Settings: special-case row spacing on Clear Browsing Data dialog (Closed)

Created:
3 years, 7 months ago by Dan Beam
Modified:
3 years, 7 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: special-case row spacing on Clear Browsing Data dialog R=dpapad@chromium.org BUG=715796 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2853763003 Cr-Commit-Position: refs/heads/master@{#468530} Committed: https://chromium.googlesource.com/chromium/src/+/d0206f11864ca3b7fd59e5f04a334c8c448349ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/controls/settings_checkbox.html View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Dan Beam
3 years, 7 months ago (2017-05-02 00:44:04 UTC) #2
dpapad
LGTM
3 years, 7 months ago (2017-05-02 01:03:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853763003/1
3 years, 7 months ago (2017-05-02 01:29:43 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 01:44:34 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d0206f11864ca3b7fd59e5f04a33...

Powered by Google App Engine
This is Rietveld 408576698