Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2853733003: webkitpy: Avoid to use webkit_base() and literal 'LayoutTests' in BaselineOptimizer (Closed)

Created:
3 years, 7 months ago by tkent
Modified:
3 years, 7 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

webkitpy: Avoid to use webkit_base() and literal 'LayoutTests' in BaselineOptimizer BaselineOptimizer handles paths relative to webkit_base, and it's not easy to update it for paths relative to LayoutTests. So, this CL just replaces - webkit_base with the parent of layout_tests_dir - ROOT_LAYOUT_TESTS_DIRECTORY with a relative path of layout_tests_dir BUG=710535 Review-Url: https://codereview.chromium.org/2853733003 Cr-Commit-Position: refs/heads/master@{#469930} Committed: https://chromium.googlesource.com/chromium/src/+/8e987fe4730ac5991bb5091c449f7e0db81b60ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer.py View 7 chunks +10 lines, -9 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer_unittest.py View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
tkent
jeffcarp@, would you review this please?
3 years, 7 months ago (2017-05-01 07:28:15 UTC) #6
jeffcarp
lgtm
3 years, 7 months ago (2017-05-01 18:27:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853733003/1
3 years, 7 months ago (2017-05-07 21:10:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/447127)
3 years, 7 months ago (2017-05-07 23:32:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853733003/1
3 years, 7 months ago (2017-05-07 23:53:22 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/447190)
3 years, 7 months ago (2017-05-08 02:14:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853733003/1
3 years, 7 months ago (2017-05-08 02:58:35 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/447235)
3 years, 7 months ago (2017-05-08 04:52:31 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853733003/1
3 years, 7 months ago (2017-05-08 05:32:36 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 09:05:32 UTC) #24
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8e987fe4730ac5991bb5091c449f...

Powered by Google App Engine
This is Rietveld 408576698