Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 285373012: Temporarily adds another constructor to Compositor (Closed)

Created:
6 years, 7 months ago by sky
Modified:
6 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org
Visibility:
Public.

Description

Temporarily adds another constructor to Compositor I'm doing this to avoid a gargantuan patch (see https://codereview.chromium.org/273073002/ for how out of control everything is right now). BUG=none TEST=none R=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271245

Patch Set 1 #

Patch Set 2 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -35 lines) Patch
M ui/compositor/compositor.h View 3 chunks +13 lines, -0 lines 0 comments Download
M ui/compositor/compositor.cc View 1 6 chunks +33 lines, -6 lines 0 comments Download
M ui/compositor/layer_unittest.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M ui/compositor/test/context_factories_for_test.h View 1 chunk +5 lines, -1 line 0 comments Download
M ui/compositor/test/context_factories_for_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/compositor/test/test_compositor_host.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/compositor/test/test_compositor_host_mac.mm View 5 chunks +14 lines, -6 lines 0 comments Download
M ui/compositor/test/test_compositor_host_ozone.cc View 4 chunks +14 lines, -6 lines 0 comments Download
M ui/compositor/test/test_compositor_host_win.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M ui/compositor/test/test_compositor_host_x11.cc View 5 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
6 years, 7 months ago (2014-05-16 23:23:49 UTC) #1
piman
LGTM
6 years, 7 months ago (2014-05-16 23:37:59 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 7 months ago (2014-05-17 02:20:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/285373012/20001
6 years, 7 months ago (2014-05-17 02:22:29 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-17 08:25:20 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-17 17:33:59 UTC) #6
Message was sent while issue was closed.
Change committed as 271245

Powered by Google App Engine
This is Rietveld 408576698