Switch SupportsUserData uses to use unique_ptr.

Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG=690937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2853663002
Cr-Commit-Position: refs/heads/master@{#468909}
Committed: https://chromium.googlesource.com/chromium/src/+/cb129c01ece3b6201a3baeceeb5b988fa49ef1be

[Avi (use Gerrit), 2017-04-29 01:12:05]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[Avi (use Gerrit), 2017-04-29 01:12:06]

Description was changed from

==========
Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG=690937
==========

to

==========
Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG=690937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2017-04-29 01:12:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 01:32:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 01:32:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2017-05-02 02:48:46]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 02:49:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-05-02 03:49:15]

avi@chromium.org changed reviewers:
+ nick@chromium.org

[Avi (use Gerrit), 2017-05-02 03:49:16]

Nick, ptal.

Requires the chrome/ changes to land first, as that exposes several destructors.

https://codereview.chromium.org/2853663002/diff/20001/content/public/browser/...
File content/public/browser/web_contents_user_data.h (right):

https://codereview.chromium.org/2853663002/diff/20001/content/public/browser/...
content/public/browser/web_contents_user_data.h:39:
contents->SetUserData(UserDataKey(), base::WrapUnique(new T(contents)));
FYI this is not MakeUnique because many many constructors are private and thus
inaccessible to MakeUnique.

[commit-bot: I haz the power, 2017-05-02 04:30:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 04:30:47]

Dry run: This issue passed the CQ dry run.

[ncarter (slow), 2017-05-02 22:23:07]

lgtm

[Avi (use Gerrit), 2017-05-03 02:50:16]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2017-05-03 02:50:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 06:49:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493779816105060,
"parent_rev": "178f9bbc1e7d7a90e3bf1e4f8033cd65c0126cfc", "commit_rev":
"cb129c01ece3b6201a3baeceeb5b988fa49ef1be"}

[commit-bot: I haz the power, 2017-05-03 06:50:04]

Description was changed from

==========
Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG=690937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG=690937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2853663002
Cr-Commit-Position: refs/heads/master@{#468909}
Committed:
https://chromium.googlesource.com/chromium/src/+/cb129c01ece3b6201a3baeceeb5b...
==========

[commit-bot: I haz the power, 2017-05-03 06:50:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cb129c01ece3b6201a3baeceeb5b...