[Crash Reporting] Improve sanitization of multipart boundary lines.

[Crash Reporting] Improve sanitization of multipart boundary lines.

The minidump uploader attempts to sanitize multipart boundary lines present in
minidumps, but was not checking for invalid characters. Only alphanumeric
characters, plus dash, are valid.

BUG=712420
TEST=MinidumpUploadCallableTest
R=gsennton@chromium.org

Review-Url: https://codereview.chromium.org/2853653002
Cr-Commit-Position: refs/heads/master@{#468478}
Committed: https://chromium.googlesource.com/chromium/src/+/faf14f70fbb1920e12c952dd64f7c4e5cb670b5b

[Ilya Sherman, 2017-04-29 00:36:57]

The CQ bit was checked by isherman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-29 00:37:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 01:31:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 01:31:08]

Dry run: This issue passed the CQ dry run.

[gsennton, 2017-04-29 08:32:50]

lgtm, modulo one comment.

Thanks for adding tests as well! :)

https://codereview.chromium.org/2853653002/diff/1/components/minidump_uploade...
File
components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadCallable.java
(right):

https://codereview.chromium.org/2853653002/diff/1/components/minidump_uploade...
components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadCallable.java:246:
// Note: The regex allows all alphanumeric characters, as well as dashes.
nit: Maybe point out why we don't allow any non-alphanumeric characters (except
dashes)? Or point to the part of the code where the boundary is generated, in
case that code is changed in the future?

[Ilya Sherman, 2017-05-01 22:30:22]

https://codereview.chromium.org/2853653002/diff/1/components/minidump_uploade...
File
components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadCallable.java
(right):

https://codereview.chromium.org/2853653002/diff/1/components/minidump_uploade...
components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadCallable.java:246:
// Note: The regex allows all alphanumeric characters, as well as dashes.
On 2017/04/29 08:32:50, gsennton wrote:
> nit: Maybe point out why we don't allow any non-alphanumeric characters
(except
> dashes)? Or point to the part of the code where the boundary is generated, in
> case that code is changed in the future?

Done.

[Ilya Sherman, 2017-05-01 22:30:31]

The CQ bit was checked by isherman@chromium.org

[Ilya Sherman, 2017-05-01 22:30:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
gsennton@chromium.org
Link to the patchset: https://codereview.chromium.org/2853653002/#ps20001
(title: "Add a comment explaining why the regex is alphanumdash")

[commit-bot: I haz the power, 2017-05-01 22:31:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 23:20:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493677831954490,
"parent_rev": "718bd5b1110f021197077f2ef41d72664b20757c", "commit_rev":
"faf14f70fbb1920e12c952dd64f7c4e5cb670b5b"}

[commit-bot: I haz the power, 2017-05-01 23:20:31]

Description was changed from

==========
[Crash Reporting] Improve sanitization of multipart boundary lines.

The minidump uploader attempts to sanitize multipart boundary lines present in
minidumps, but was not checking for invalid characters. Only alphanumeric
characters, plus dash, are valid.

BUG=712420
TEST=MinidumpUploadCallableTest
R=gsennton@chromium.org
==========

to

==========
[Crash Reporting] Improve sanitization of multipart boundary lines.

The minidump uploader attempts to sanitize multipart boundary lines present in
minidumps, but was not checking for invalid characters. Only alphanumeric
characters, plus dash, are valid.

BUG=712420
TEST=MinidumpUploadCallableTest
R=gsennton@chromium.org

Review-Url: https://codereview.chromium.org/2853653002
Cr-Commit-Position: refs/heads/master@{#468478}
Committed:
https://chromium.googlesource.com/chromium/src/+/faf14f70fbb1920e12c952dd64f7...
==========

[commit-bot: I haz the power, 2017-05-01 23:20:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/faf14f70fbb1920e12c952dd64f7...