Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2853533002: Remove DumpWithoutCrashing for HasPermissionsForFileSystemFile/CanCommitURL. (Closed)

Created:
3 years, 7 months ago by Łukasz Anforowicz
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Remove DumpWithoutCrashing for HasPermissionsForFileSystemFile/CanCommitURL. This DumpWithoutCrashing turned out to be non-actionable (see https://crbug.com/654479#c35). Furthermore some forbidden accesses seem unavoidable and in such cases DumpWithoutCrashing causes unnecessary jank/latency during legitimate drag-and-drop scenarios (in case of cross-site dragover/dragenter/dragleave that drags filesystem URIs - see https://crbug.com/705295#c30). BUG=654479, 705295 Review-Url: https://codereview.chromium.org/2826693003 Cr-Commit-Position: refs/heads/master@{#465317} (cherry picked from commit c1ef2baa3dc05e2879e28bc22301e6bd713adad3) Review-Url: https://codereview.chromium.org/2853533002 . Cr-Commit-Position: refs/branch-heads/3071@{#295} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/daca1351774c52279fede4e295f2a29642bc331c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/browser/child_process_security_policy_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Łukasz Anforowicz
3 years, 7 months ago (2017-04-28 15:43:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
daca1351774c52279fede4e295f2a29642bc331c.

Powered by Google App Engine
This is Rietveld 408576698