Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Issue 2853513002: Move part of initialization tasks to ProcessInitializationHandler (Closed)

Created:
3 years, 7 months ago by bsazonov
Modified:
3 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move part of initialization tasks to ProcessInitializationHandler This CL moves part of deferred initialization tasks from DeferredStartupHandler to ProcessInitializationHandler to split responsibilities. BUG=716454 Review-Url: https://codereview.chromium.org/2853513002 Cr-Commit-Position: refs/heads/master@{#468605} Committed: https://chromium.googlesource.com/chromium/src/+/172ca56fe77575d9be332eaecd4c958fc07d5c3c

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -38 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java View 3 chunks +0 lines, -33 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java View 1 6 chunks +39 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (17 generated)
Ted C
lgtm! https://codereview.chromium.org/2853513002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java File chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java (right): https://codereview.chromium.org/2853513002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java#newcode204 chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java:204: DeferredStartupHandler.getInstance().addDeferredTask(new Runnable() { Maybe pull out a variable ...
3 years, 7 months ago (2017-04-28 17:41:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853513002/20001
3 years, 7 months ago (2017-05-02 12:06:24 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 12:11:17 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/172ca56fe77575d9be332eaecd4c...

Powered by Google App Engine
This is Rietveld 408576698