Enable build with shared libraries.

Enable build with shared libraries.

This adaptation will allow build v8 when the component is defined as
shared library. Without this, at linking phase of the unittests will be
displayed error messages for undefined references.

TEST=
BUG=

Review-Url: https://codereview.chromium.org/2853483002
Cr-Commit-Position: refs/heads/master@{#45126}
Committed: https://chromium.googlesource.com/v8/v8/+/d7f7c324245ca78ef03d7d8a893bee40b07b19bd

[Ilija.Pavlovic1, 2017-04-28 05:59:22]

ilija.pavlovic@imgtec.com changed reviewers:
+ ivica.bogosavljevic@imgtec.com, jochen@chromium.org, leszeks@chromium.org,
machenbach@chromium.org, miran.karic@imgtec.com, mlippautz@chromium.org,
rmcilroy@chromium.org

[Ilija.Pavlovic1, 2017-04-28 05:59:23]

PTAL

[Michael Achenbach, 2017-04-28 07:38:55]

lgtm

[jochen (gone - plz use gerrit), 2017-04-28 07:47:23]

not LGTM

We should instead fix the missing symbols and undo the linking against v8 base
directly

[Michael Achenbach, 2017-04-28 08:38:32]

Why is this currently working with GN?

[jochen (gone - plz use gerrit), 2017-04-28 08:47:17]

On 2017/04/28 at 08:38:32, machenbach wrote:
> Why is this currently working with GN?

It's not writing on GN either :/

Preparing a fix

[jochen (gone - plz use gerrit), 2017-04-28 10:08:54]

gn fix here: https://chromium-review.googlesource.com/c/490108/

still needs to be ported to gyp

[Ilija.Pavlovic1, 2017-05-03 10:08:09]

PTAL

[Ilija.Pavlovic1, 2017-05-04 08:08:55]

ping

[Ilija.Pavlovic1, 2017-05-05 09:32:47]

@Jochen, @Achenbach: I would ask you to review this. This change is only one
line.

[Michael Achenbach, 2017-05-05 09:40:17]

Is this one-liner enough? I had the impression from jochen's comment that
https://chromium-review.googlesource.com/c/490108/ needs to be ported to gyp.

I'm not going to block this as we're on the path of deprecating gyp. But it's up
to jochen to remove the "not l-g-t-m".

[jochen (gone - plz use gerrit), 2017-05-05 09:43:40]

On 2017/05/05 at 09:40:17, machenbach wrote:
> Is this one-liner enough? I had the impression from jochen's comment that
https://chromium-review.googlesource.com/c/490108/ needs to be ported to gyp.
> 
> I'm not going to block this as we're on the path of deprecating gyp. But it's
up to jochen to remove the "not l-g-t-m".

What's the plan for gyp? It seems that the gyp build is faster and faster
getting out of sync with GN at this point...

The gyp build would need the new targets for the builtins generators as well as
the V8_for_testing target to get unittests compile correctly in a component
build

[Michael Achenbach, 2017-05-05 09:48:13]

> What's the plan for gyp? It seems that the gyp build is faster and faster
> getting out of sync with GN at this point...

The plan is:
https://groups.google.com/forum/#!topic/v8-dev/rtqGzl-L-X0

I.e. this file will be deleted by end-of-year. Embedders who still need it must
copy it into their own projects. Node.js for example doesn't run unittests, so
there it's not needed.

[jochen (gone - plz use gerrit), 2017-05-05 09:54:52]

So if we don't promise to add new stuff to gyp anymore, it's kinda expected that
it already now didn't work anymore.

How do we decide what patches to accept for gyp at this point?

[Michael Achenbach, 2017-05-05 10:00:48]

On 2017/05/05 09:54:52, jochen wrote:
> So if we don't promise to add new stuff to gyp anymore, it's kinda expected
that
> it already now didn't work anymore.
> 
> How do we decide what patches to accept for gyp at this point?

I'm fine with anything that doesn't break the remaining gyp bots in our
infrastructure, e.g. the node_integration bot and the gyp bot running in CQ.

[jochen (gone - plz use gerrit), 2017-05-05 10:16:54]

ok, lgtm then

[Ilija.Pavlovic1, 2017-05-05 10:26:21]

The CQ bit was checked by ilija.pavlovic@imgtec.com

[Ilija.Pavlovic1, 2017-05-05 10:26:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2853483002/#ps20001
(title: "Using target v8_maybe_snapshot.")

[commit-bot: I haz the power, 2017-05-05 10:26:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 10:59:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493979981548820,
"parent_rev": "25959abf7948b7caac1ec844ed332b5fc4aa7ebb", "commit_rev":
"d7f7c324245ca78ef03d7d8a893bee40b07b19bd"}

[commit-bot: I haz the power, 2017-05-05 10:59:46]

Description was changed from

==========
Enable build with shared libraries.

This adaptation will allow build v8 when the component is defined as
shared library. Without this, at linking phase of the unittests will be
displayed error messages for undefined references.

TEST=
BUG=
==========

to

==========
Enable build with shared libraries.

This adaptation will allow build v8 when the component is defined as
shared library. Without this, at linking phase of the unittests will be
displayed error messages for undefined references.

TEST=
BUG=

Review-Url: https://codereview.chromium.org/2853483002
Cr-Commit-Position: refs/heads/master@{#45126}
Committed:
https://chromium.googlesource.com/v8/v8/+/d7f7c324245ca78ef03d7d8a893bee40b07...
==========

[commit-bot: I haz the power, 2017-05-05 10:59:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/d7f7c324245ca78ef03d7d8a893bee40b07...