Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2853473002: Always return false on IsHandlingSendingEvent (Closed)

Created:
3 years, 7 months ago by dvallet
Modified:
3 years, 7 months ago
Reviewers:
Sami, dvallet1
CC:
chromium-reviews, mac-reviews_chromium.org, Oleg Sushkov
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Always return false on IsHandlingSendingEvent This fixes an issue on closing Web contents on headless Mac, since it makes think Web contents that the current view is still handling UI events. See https://cs.chromium.org/chromium/src/content/browser/web_contents/web_contents_view.h?rcl=e0bef062337921727eb9b670b417ebd0b6d86fd6&l=131 BUG=713268 Review-Url: https://codereview.chromium.org/2853473002 Cr-Commit-Position: refs/heads/master@{#468132} Committed: https://chromium.googlesource.com/chromium/src/+/ae6a5e9c0b09c7c856a0eb160e2ad071d6ef7d7f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M headless/lib/browser/headless_shell_application_mac.mm View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dvallet1
3 years, 7 months ago (2017-04-28 04:46:47 UTC) #2
Sami
lgtm, thanks!
3 years, 7 months ago (2017-04-28 17:03:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853473002/1
3 years, 7 months ago (2017-04-28 21:18:11 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 21:26:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ae6a5e9c0b09c7c856a0eb160e2a...

Powered by Google App Engine
This is Rietveld 408576698