Issue 2853453002: Android: Fire the appinstalled event on WebAPK installation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2853453002: Android: Fire the appinstalled event on WebAPK installation. (Closed)

Created:
3 years, 7 months ago by Matt Giuca

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3071

Project:
chromium

Visibility:
Public.

Android: Fire the appinstalled event on WebAPK installation. Previously, it would only fire for a shortcut creation (when the app is not associated with a WebAPK). BUG=688178 Review-Url: https://codereview.chromium.org/2670963002 Cr-Commit-Position: refs/heads/master@{#466580} (cherry picked from commit 00e4fb83516d445e8952416ed29a481b399a0a24) Review-Url: https://codereview.chromium.org/2853453002 . Cr-Commit-Position: refs/branch-heads/3071@{#283} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/689f6f169613b54863f46d2b7d6dd322075b3f55

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -20 lines)			Patch
M	chrome/browser/android/banners/app_banner_infobar_delegate_android.cc	View	1 chunk	+10 lines, -6 lines	0 comments	Download
M	chrome/browser/android/webapps/add_to_homescreen_manager.cc	View	3 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/browser/banners/app_banner_manager.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/banners/app_banner_manager.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 2 (1 generated)

Matt Giuca

3 years, 7 months ago (2017-04-28 04:11:10 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
689f6f169613b54863f46d2b7d6dd322075b3f55 (tree was closed).