Switch SupportsUserData uses to use unique_ptr.

Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG=690937
Review-Url: https://codereview.chromium.org/2853443002
Cr-Commit-Position: refs/heads/master@{#468008}
Committed: https://chromium.googlesource.com/chromium/src/+/37c9356daeb495268f0ccc950c2c8095c0edd0e9

[Avi (use Gerrit), 2017-04-28 01:38:42]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 01:39:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 02:01:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 02:01:12]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2017-04-28 02:03:25]

avi@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2017-04-28 10:07:05]

lgtm (with one suggested change that can be done in a followup)

https://codereview.chromium.org/2853443002/diff/1/ios/chrome/browser/ui/dialo...
File ios/chrome/browser/ui/dialogs/javascript_dialog_blocking_util.mm (right):

https://codereview.chromium.org/2853443002/diff/1/ios/chrome/browser/ui/dialo...
ios/chrome/browser/ui/dialogs/javascript_dialog_blocking_util.mm:54: explicit
JavaScriptDialogBlockingStateWrapper(web::WebState* web_state)
Can you change this constructor to not take the web::WebState* and instead call
SetUserData in FromWebState:

  static JavaScriptDialogBlockingStateWrapper* FromWebState(
      web::WebState* web_state) {
    DCHECK(web_state);
    JavaScriptDialogBlockingStateWrapper* wrapper =
        static_cast<JavaScriptDialogBlockingStateWrapper*>(
            web_state->GetUserData(kBlockingStateKey));
    if (!wrapper) {
        wrapper = new JavaScriptDialogBlockingStateWrapper();
        web_state->SetUserData(kBlockingStateKey, base::WrapUnique(wrapper));
    }
    return wrapper;
  }

 private:
  JavaScriptDialogBlockingStateWrapper() = default;

[sdefresne, 2017-04-28 10:07:15]

Thank you for this cleanup BTW.

[Avi (use Gerrit), 2017-04-28 15:23:56]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2017-04-28 15:24:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 15:33:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493393036937780, "parent_rev":
"e04941a0e5810c69846b52f664efae23431b1458", "commit_rev":
"37c9356daeb495268f0ccc950c2c8095c0edd0e9"}

[commit-bot: I haz the power, 2017-04-28 15:33:45]

Description was changed from

==========
Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG=690937
==========

to

==========
Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG=690937

Review-Url: https://codereview.chromium.org/2853443002
Cr-Commit-Position: refs/heads/master@{#468008}
Committed:
https://chromium.googlesource.com/chromium/src/+/37c9356daeb495268f0ccc950c2c...
==========

[commit-bot: I haz the power, 2017-04-28 15:33:46]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/37c9356daeb495268f0ccc950c2c...