Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 2853393003: [TTS] Fix flaky second-tap on tap-selection. (Closed)

Created:
3 years, 7 months ago by Donn Denman
Modified:
3 years, 7 months ago
Reviewers:
Theresa
CC:
chromium-reviews, twellington+watch_chromium.org, donnd+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[TTS] Fix flaky second-tap on tap-selection. When a Tap selection is present, a second tap shows the pins, and the Bar should keep showing. However this seems to currently be flaky. This CL adds a check when a Tap is recognized to see if we're already showing a Tap-selection. We were incorrectly starting a Tap sequence in response to this second tap but that's not needed since we'll soon get a message for the Long-press gesture when the pins show. BUG=717942 Review-Url: https://codereview.chromium.org/2853393003 Cr-Commit-Position: refs/heads/master@{#469033} Committed: https://chromium.googlesource.com/chromium/src/+/b789be39ee73d0f5e834d3f0a1e3ef88d59d10bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchInternalStateController.java View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Donn Denman
Theresa, PTAL.
3 years, 7 months ago (2017-05-03 17:13:13 UTC) #3
Theresa
lgtm
3 years, 7 months ago (2017-05-03 17:15:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853393003/1
3 years, 7 months ago (2017-05-03 17:58:35 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 18:06:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b789be39ee73d0f5e834d3f0a1e3...

Powered by Google App Engine
This is Rietveld 408576698