[builtins] Migrate Object.keys to CodeStubAssembler builtin.

[builtins] Migrate Object.keys to CodeStubAssembler builtin.

Migrate the Object.keys builtin to the CodeStubAssembler and
use the enum cache backing store whenever it is available. This
gives a nice speedup of 1.5x to 2x when using Object.keys on fast-mode
objects that have (or can have) an enum cache.

R=cbruni@chromium.org
BUG=v8:5269, v8:6405
Review-Url: https://codereview.chromium.org/2853393002
Cr-Commit-Position: refs/heads/master@{#45361}
Committed: https://chromium.googlesource.com/v8/v8/+/c8c758053b7326023458c8cc2bcbd8b3bd95b904

[Benedikt Meurer, 2017-05-02 19:08:54]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 19:09:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-05-02 19:09:21]

Hey Camillo,

Here's the patch for Object.keys that we discussed today.
Please take a look.

Thanks,
Benedikt

[commit-bot: I haz the power, 2017-05-02 19:33:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 19:33:52]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Benedikt Meurer, 2017-05-03 02:09:51]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 02:09:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 02:27:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 02:27:48]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Benedikt Meurer, 2017-05-03 05:42:30]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 05:42:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 06:05:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 06:05:30]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/25365)
  v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)

[Camillo Bruni, 2017-05-03 08:40:44]

LGTM modulo the right-trimming issues.

https://codereview.chromium.org/2853393002/diff/30001/test/mjsunit/object-key...
File test/mjsunit/object-keys.js (right):

https://codereview.chromium.org/2853393002/diff/30001/test/mjsunit/object-key...
test/mjsunit/object-keys.js:9: let k = Object.keys(a);
You could additionally do: %VerifyHeapObject(k)

[Benedikt Meurer, 2017-05-17 05:08:07]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 05:08:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-05-17 05:09:19]

https://codereview.chromium.org/2853393002/diff/30001/test/mjsunit/object-key...
File test/mjsunit/object-keys.js (right):

https://codereview.chromium.org/2853393002/diff/30001/test/mjsunit/object-key...
test/mjsunit/object-keys.js:9: let k = Object.keys(a);
On 2017/05/03 08:40:44, Camillo Bruni wrote:
> You could additionally do: %VerifyHeapObject(k)

Done.

[Benedikt Meurer, 2017-05-17 05:17:30]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 05:17:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-05-17 05:18:33]

Description was changed from

==========
[builtins] Migrate Object.keys to CodeStubAssembler builtin.

Change the enum cache to use the fixed_cow_array_map instead of the
plain fixed_array_map, which allows us to use the enum cache as the
backing store for JSArray objects returned from Object.keys - avoiding
the copying of the keys completely.

Based on this, migrate the Object.keys builtin to the CodeStubAssembler
and use the enum cache backing store whenever it is available. This
gives a nice speedup of 1.5x to 2x when using Object.keys on fast-mode
objects that have (or can have) an enum cache.

R=cbruni@chromium.org
BUG=v8:5269
==========

to

==========
[builtins] Migrate Object.keys to CodeStubAssembler builtin.

Change the enum cache to use the fixed_cow_array_map instead of the
plain fixed_array_map, which allows us to use the enum cache as the
backing store for JSArray objects returned from Object.keys - avoiding
the copying of the keys completely.

Based on this, migrate the Object.keys builtin to the CodeStubAssembler
and use the enum cache backing store whenever it is available. This
gives a nice speedup of 1.5x to 2x when using Object.keys on fast-mode
objects that have (or can have) an enum cache. This also means that
we can no longer (safely) right trim enum caches, but that's probably
not necessary anyways (if it turns out to cause trouble in real world
we can start thinking about other mitigations).

R=cbruni@chromium.org
TBR=ulan@chromium.org
BUG=v8:5269
==========

[Benedikt Meurer, 2017-05-17 05:22:34]

Description was changed from

==========
[builtins] Migrate Object.keys to CodeStubAssembler builtin.

Change the enum cache to use the fixed_cow_array_map instead of the
plain fixed_array_map, which allows us to use the enum cache as the
backing store for JSArray objects returned from Object.keys - avoiding
the copying of the keys completely.

Based on this, migrate the Object.keys builtin to the CodeStubAssembler
and use the enum cache backing store whenever it is available. This
gives a nice speedup of 1.5x to 2x when using Object.keys on fast-mode
objects that have (or can have) an enum cache. This also means that
we can no longer (safely) right trim enum caches, but that's probably
not necessary anyways (if it turns out to cause trouble in real world
we can start thinking about other mitigations).

R=cbruni@chromium.org
TBR=ulan@chromium.org
BUG=v8:5269
==========

to

==========
[builtins] Migrate Object.keys to CodeStubAssembler builtin.

Change the enum cache to use the fixed_cow_array_map instead of the
plain fixed_array_map, which allows us to use the enum cache as the
backing store for JSArray objects returned from Object.keys - avoiding
the copying of the keys completely.

Based on this, migrate the Object.keys builtin to the CodeStubAssembler
and use the enum cache backing store whenever it is available. This
gives a nice speedup of 1.5x to 2x when using Object.keys on fast-mode
objects that have (or can have) an enum cache. This also means that
we can no longer (safely) right trim enum caches, but that's probably
not necessary anyways (if it turns out to cause trouble in real world
we can start thinking about other mitigations).

R=cbruni@chromium.org
TBR=ulan@chromium.org
BUG=v8:5269,v8:6405
==========

[Benedikt Meurer, 2017-05-17 05:22:49]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2017-05-17 05:22:53]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2017-05-17 05:22:54]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/2853393002/#ps70001
(title: "Remove trimming of enum caches.")

[commit-bot: I haz the power, 2017-05-17 05:22:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 06:08:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 06:08:07]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Benedikt Meurer, 2017-05-17 07:39:38]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 07:39:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-05-17 07:40:20]

Description was changed from

==========
[builtins] Migrate Object.keys to CodeStubAssembler builtin.

Change the enum cache to use the fixed_cow_array_map instead of the
plain fixed_array_map, which allows us to use the enum cache as the
backing store for JSArray objects returned from Object.keys - avoiding
the copying of the keys completely.

Based on this, migrate the Object.keys builtin to the CodeStubAssembler
and use the enum cache backing store whenever it is available. This
gives a nice speedup of 1.5x to 2x when using Object.keys on fast-mode
objects that have (or can have) an enum cache. This also means that
we can no longer (safely) right trim enum caches, but that's probably
not necessary anyways (if it turns out to cause trouble in real world
we can start thinking about other mitigations).

R=cbruni@chromium.org
TBR=ulan@chromium.org
BUG=v8:5269,v8:6405
==========

to

==========
[builtins] Migrate Object.keys to CodeStubAssembler builtin.

Migrate the Object.keys builtin to the CodeStubAssembler and
use the enum cache backing store whenever it is available. This
gives a nice speedup of 1.5x to 2x when using Object.keys on fast-mode
objects that have (or can have) an enum cache.

R=cbruni@chromium.org
BUG=v8:5269,v8:6405
==========

[commit-bot: I haz the power, 2017-05-17 07:59:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 07:59:59]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Benedikt Meurer, 2017-05-17 08:07:11]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 08:07:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-05-17 08:12:02]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 08:12:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-05-17 08:12:31]

Patchset #7 (id:110001) has been deleted

[Benedikt Meurer, 2017-05-17 08:12:39]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2017-05-17 08:12:43]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2017-05-17 08:12:44]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/2853393002/#ps130001
(title: "Really fix the test, meh.")

[commit-bot: I haz the power, 2017-05-17 08:12:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 08:45:31]

CQ is committing da patch.

Bot data: {"patchset_id": 130001, "attempt_start_ts": 1495008763641800,
"parent_rev": "15805b2d537c92b98a6c8db6a464dcefe07f4910", "commit_rev":
"c8c758053b7326023458c8cc2bcbd8b3bd95b904"}

[commit-bot: I haz the power, 2017-05-17 08:45:39]

Description was changed from

==========
[builtins] Migrate Object.keys to CodeStubAssembler builtin.

Migrate the Object.keys builtin to the CodeStubAssembler and
use the enum cache backing store whenever it is available. This
gives a nice speedup of 1.5x to 2x when using Object.keys on fast-mode
objects that have (or can have) an enum cache.

R=cbruni@chromium.org
BUG=v8:5269,v8:6405
==========

to

==========
[builtins] Migrate Object.keys to CodeStubAssembler builtin.

Migrate the Object.keys builtin to the CodeStubAssembler and
use the enum cache backing store whenever it is available. This
gives a nice speedup of 1.5x to 2x when using Object.keys on fast-mode
objects that have (or can have) an enum cache.

R=cbruni@chromium.org
BUG=v8:5269,v8:6405

Review-Url: https://codereview.chromium.org/2853393002
Cr-Commit-Position: refs/heads/master@{#45361}
Committed:
https://chromium.googlesource.com/v8/v8/+/c8c758053b7326023458c8cc2bcbd8b3bd9...
==========

[commit-bot: I haz the power, 2017-05-17 08:45:40]

Committed patchset #7 (id:130001) as
https://chromium.googlesource.com/v8/v8/+/c8c758053b7326023458c8cc2bcbd8b3bd9...