Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2853373003: [Web Payments] Explicitly move SheetView (Closed)

Created:
3 years, 7 months ago by anthonyvd
Modified:
3 years, 7 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Web Payments] Explicitly move SheetView BUG=717612 Review-Url: https://codereview.chromium.org/2853373003 Cr-Commit-Position: refs/heads/master@{#468723} Committed: https://chromium.googlesource.com/chromium/src/+/bf16ab86c8929ad72134db3d09bd3681e70bd9e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/payments/payment_request_sheet_controller.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
anthonyvd
Hi Math, can you PTAL? This patch should fix the failing build mentioned in the ...
3 years, 7 months ago (2017-05-02 17:53:06 UTC) #2
Mathieu
I thought it would have been fixed by copy ellision, but lgtm!
3 years, 7 months ago (2017-05-02 17:54:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853373003/1
3 years, 7 months ago (2017-05-02 17:55:40 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 18:53:15 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bf16ab86c8929ad72134db3d09bd...

Powered by Google App Engine
This is Rietveld 408576698