[Reland][Mac] Refactor bookmark bar controller

[Reland][Mac] Refactor bookmark bar controller

Fixed MSan issue (https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FMac_ASan_64_Tests__1_%2F29660%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FBookmarkFolderAppleScriptTest.DeleteBookmarkItems%2F0)

See delta between patchsets 2 and 3 for the fix

Original description:
Yes, with RTL thrown in, since this is specifically designed to make it almost free.

Two major things here:
- The bar is no longer relaid-out directly in response to changes in view size, bookmark model etc. Instead, a new UI-direction-agnostic view model (BookmarkBarLayout) is created from the current state, and if it's different from before, it's applied to the view.
- Removed a bunch of layout-related code that's no longer necessary

BUG=648560
Review-Url: https://codereview.chromium.org/2751573002
Cr-Commit-Position: refs/heads/master@{#468364}
Committed: https://chromium.googlesource.com/chromium/src/+/2644729cb7722a702a76cc2758d0ce372e1e6f92

patch from issue 2751573002 at patchset 180001 (http://crrev.com/2751573002#ps180001)

Review-Url: https://codereview.chromium.org/2853373002
Cr-Commit-Position: refs/heads/master@{#468981}
Committed: https://chromium.googlesource.com/chromium/src/+/cdde49adc3b921524027132523cb538bfa670cd4

[lgrey, 2017-05-02 17:33:29]

The CQ bit was checked by lgrey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 17:33:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 17:56:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 17:56:29]

Dry run: This issue passed the CQ dry run.

[lgrey, 2017-05-02 18:27:57]

Patchset #2 (id:20001) has been deleted

[lgrey, 2017-05-02 18:35:21]

Description was changed from

==========
[Reland][Mac] Refactor bookmark bar controller

Fixed MSan issue
(https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FMac_AS...)

Original description:
Yes, with RTL thrown in, since this is specifically designed to make it almost
free.

Two major things here:
- The bar is no longer relaid-out directly in response to changes in view size,
bookmark model etc. Instead, a new UI-direction-agnostic view model
(BookmarkBarLayout) is created from the current state, and if it's different
from before, it's applied to the view.
- Removed a bunch of layout-related code that's no longer necessary

BUG=648560

Review-Url: https://codereview.chromium.org/2751573002
Cr-Commit-Position: refs/heads/master@{#468364}
Committed:
https://chromium.googlesource.com/chromium/src/+/2644729cb7722a702a76cc2758d0...

patch from issue 2751573002 at patchset 180001
(http://crrev.com/2751573002#ps180001)
==========

to

==========
[Reland][Mac] Refactor bookmark bar controller

Fixed MSan issue
(https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FMac_AS...)

See delta between patchsets 2 and 3 for the fix

Original description:
Yes, with RTL thrown in, since this is specifically designed to make it almost
free.

Two major things here:
- The bar is no longer relaid-out directly in response to changes in view size,
bookmark model etc. Instead, a new UI-direction-agnostic view model
(BookmarkBarLayout) is created from the current state, and if it's different
from before, it's applied to the view.
- Removed a bunch of layout-related code that's no longer necessary

BUG=648560

Review-Url: https://codereview.chromium.org/2751573002
Cr-Commit-Position: refs/heads/master@{#468364}
Committed:
https://chromium.googlesource.com/chromium/src/+/2644729cb7722a702a76cc2758d0...

patch from issue 2751573002 at patchset 180001
(http://crrev.com/2751573002#ps180001)
==========

[lgrey, 2017-05-02 19:44:20]

The CQ bit was checked by lgrey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 19:44:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 20:19:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 20:19:08]

Dry run: This issue passed the CQ dry run.

[lgrey, 2017-05-02 20:19:54]

lgrey@chromium.org changed reviewers:
+ avi@chromium.org, ellyjones@chromium.org

[lgrey, 2017-05-02 20:19:57]

PTAL :)

[Avi (use Gerrit), 2017-05-02 20:31:45]

lgtm

[Elly Fong-Jones, 2017-05-03 15:21:05]

On 2017/05/02 20:31:45, Avi (ping after 24h) wrote:
> lgtm

lgtm :)

[lgrey, 2017-05-03 15:23:14]

The CQ bit was checked by lgrey@chromium.org

[commit-bot: I haz the power, 2017-05-03 15:23:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 15:29:39]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493824994304950,
"parent_rev": "1e21bd3a8b2257bf96283f1ab9a12f09e55b3acf", "commit_rev":
"cdde49adc3b921524027132523cb538bfa670cd4"}

[commit-bot: I haz the power, 2017-05-03 15:29:46]

Description was changed from

==========
[Reland][Mac] Refactor bookmark bar controller

Fixed MSan issue
(https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FMac_AS...)

See delta between patchsets 2 and 3 for the fix

Original description:
Yes, with RTL thrown in, since this is specifically designed to make it almost
free.

Two major things here:
- The bar is no longer relaid-out directly in response to changes in view size,
bookmark model etc. Instead, a new UI-direction-agnostic view model
(BookmarkBarLayout) is created from the current state, and if it's different
from before, it's applied to the view.
- Removed a bunch of layout-related code that's no longer necessary

BUG=648560

Review-Url: https://codereview.chromium.org/2751573002
Cr-Commit-Position: refs/heads/master@{#468364}
Committed:
https://chromium.googlesource.com/chromium/src/+/2644729cb7722a702a76cc2758d0...

patch from issue 2751573002 at patchset 180001
(http://crrev.com/2751573002#ps180001)
==========

to

==========
[Reland][Mac] Refactor bookmark bar controller

Fixed MSan issue
(https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FMac_AS...)

See delta between patchsets 2 and 3 for the fix

Original description:
Yes, with RTL thrown in, since this is specifically designed to make it almost
free.

Two major things here:
- The bar is no longer relaid-out directly in response to changes in view size,
bookmark model etc. Instead, a new UI-direction-agnostic view model
(BookmarkBarLayout) is created from the current state, and if it's different
from before, it's applied to the view.
- Removed a bunch of layout-related code that's no longer necessary

BUG=648560

Review-Url: https://codereview.chromium.org/2751573002
Cr-Commit-Position: refs/heads/master@{#468364}
Committed:
https://chromium.googlesource.com/chromium/src/+/2644729cb7722a702a76cc2758d0...

patch from issue 2751573002 at patchset 180001
(http://crrev.com/2751573002#ps180001)

Review-Url: https://codereview.chromium.org/2853373002
Cr-Commit-Position: refs/heads/master@{#468981}
Committed:
https://chromium.googlesource.com/chromium/src/+/cdde49adc3b921524027132523cb...
==========

[commit-bot: I haz the power, 2017-05-03 15:29:49]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cdde49adc3b921524027132523cb...