Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(76)

Issue 2853363002: Rename the DownloadService to DownloadCoreService (Closed)

Created:
2 years, 11 months ago by Peter Beverloo
Modified:
2 years, 11 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, msramek+watch_chromium.org, oka+watch_chromium.org, ntp-dev+reviews_chromium.org, tfarina, yamaguchi+watch_chromium.org, mac-reviews_chromium.org, David Trainor- moved to gerrit, rginda+watch_chromium.org, noyau+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, chromium-apps-reviews_chromium.org, markusheintz_, dbeam+watch-downloads_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename the DownloadService to DownloadCoreService The class currently named DownloadService provides access to a number of internal details to the core of the download system in Chrome. While it's a service in that it's a KeyedService with a factory, it's not *the* service that services downloads. A new project has been started to add an actual download service, that enables different systems in Chrome to download files. That's the thing that really should be called DownloadService. BUG= Review-Url: https://codereview.chromium.org/2853363002 Cr-Commit-Position: refs/heads/master@{#468729} Committed: https://chromium.googlesource.com/chromium/src/+/ccb33e88ae90c672f98cd24ac631bc92581a199f

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -723 lines) Patch
M chrome/browser/BUILD.gn View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/android/download/download_manager_service.cc View 2 chunks +5 lines, -5 lines 1 comment Download
M chrome/browser/app_controller_mac.mm View 3 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/browsing_data/downloads_counter_browsertest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/download_handler.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_integration_service.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 3 chunks +10 lines, -8 lines 0 comments Download
A + chrome/browser/download/download_core_service.h View 3 chunks +9 lines, -9 lines 0 comments Download
A + chrome/browser/download/download_core_service.cc View 1 chunk +14 lines, -16 lines 0 comments Download
A chrome/browser/download/download_core_service_factory.h View 1 chunk +39 lines, -0 lines 0 comments Download
A + chrome/browser/download/download_core_service_factory.cc View 2 chunks +14 lines, -15 lines 0 comments Download
A + chrome/browser/download/download_core_service_impl.h View 3 chunks +9 lines, -9 lines 0 comments Download
A + chrome/browser/download/download_core_service_impl.cc View 7 chunks +13 lines, -15 lines 0 comments Download
M chrome/browser/download/download_item_model.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/download/download_prefs.cc View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/download/download_service.h View 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/download/download_service.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/download/download_service_factory.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/download/download_service_factory.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/download/download_service_impl.h View 1 chunk +0 lines, -88 lines 0 comments Download
D chrome/browser/download/download_service_impl.cc View 1 chunk +0 lines, -153 lines 0 comments Download
M chrome/browser/download/download_shelf.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/download/download_shelf_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_test_file_activity_observer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/download/download_ui_controller_unittest.cc View 6 chunks +20 lines, -21 lines 0 comments Download
M chrome/browser/download/notification/download_notification_browsertest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.cc View 4 chunks +14 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_unittest.cc View 6 chunks +19 lines, -18 lines 0 comments Download
M chrome/browser/lifetime/application_lifetime.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/lifetime/browser_close_manager.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/lifetime/browser_close_manager_browsertest.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ntp_snippets/content_suggestions_service_factory.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/ui/browser_close_unittest.cc View 4 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/md_downloads/md_downloads_ui.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Peter Beverloo
+dtrainor for downloads & review +thakis for //chrome/browser/ stamp
2 years, 11 months ago (2017-05-02 17:18:20 UTC) #4
David Trainor- moved to gerrit
lgtm thanks so much for doing this! :) https://codereview.chromium.org/2853363002/diff/1/chrome/browser/android/download/download_manager_service.cc File chrome/browser/android/download/download_manager_service.cc (right): https://codereview.chromium.org/2853363002/diff/1/chrome/browser/android/download/download_manager_service.cc#newcode15 chrome/browser/android/download/download_manager_service.cc:15: #include ...
2 years, 11 months ago (2017-05-02 18:36:25 UTC) #7
Nico
lgtm
2 years, 11 months ago (2017-05-02 18:51:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853363002/1
2 years, 11 months ago (2017-05-02 18:52:08 UTC) #10
commit-bot: I haz the power
2 years, 11 months ago (2017-05-02 19:01:34 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ccb33e88ae90c672f98cd24ac631...

Powered by Google App Engine
This is Rietveld 408576698