Remove use_selection_height from LayoutText::AbsoluteQuadsForRange

Remove use_selection_height from LayoutText::AbsoluteQuadsForRange

All calls to LayoutText::AbsoluteQuadsForRange don't use use_selection_height,
so use_selection_height is removed from LayoutText::AbsoluteQuadsForRange and
its callee functions.

BUG=691198
Review-Url: https://codereview.chromium.org/2853343003
Cr-Commit-Position: refs/heads/master@{#469295}
Committed: https://chromium.googlesource.com/chromium/src/+/d463bb0d71db8246590f488ba5dba62e3ae56876

[tanvir, 2017-05-03 06:13:35]

Description was changed from

==========
Remove use_selection_height from LayoutText::AbsoluteQuadsForRange

Remove use_selection_height from LayoutText::AbsoluteQuadsForRange

All calls to LayoutText::AbsoluteQuadsForRange don't use use_selection_height,
so use_selection_height is removed from LayoutText::AbsoluteQuadsForRange and
its callee functions.

BUG=691198
==========

to

==========
Remove use_selection_height from LayoutText::AbsoluteQuadsForRange

Remove use_selection_height from LayoutText::AbsoluteQuadsForRange

All calls to LayoutText::AbsoluteQuadsForRange don't use use_selection_height,
so use_selection_height is removed from LayoutText::AbsoluteQuadsForRange and
its callee functions.

BUG=691198
==========

[tanvir, 2017-05-03 06:13:35]

tanvir.rizvi@samsung.com changed reviewers:
+ shanmuga.m@samsung.com, srirama.m@chromium.org

[tanvir, 2017-05-03 06:14:29]

Description was changed from

==========
Remove use_selection_height from LayoutText::AbsoluteQuadsForRange

Remove use_selection_height from LayoutText::AbsoluteQuadsForRange

All calls to LayoutText::AbsoluteQuadsForRange don't use use_selection_height,
so use_selection_height is removed from LayoutText::AbsoluteQuadsForRange and
its callee functions.

BUG=691198
==========

to

==========
Remove use_selection_height from LayoutText::AbsoluteQuadsForRange

All calls to LayoutText::AbsoluteQuadsForRange don't use use_selection_height,
so use_selection_height is removed from LayoutText::AbsoluteQuadsForRange and
its callee functions.

BUG=691198
==========

[Srirama, 2017-05-03 06:22:59]

srirama.m@samsung.com changed reviewers:
+ srirama.m@samsung.com

[Srirama, 2017-05-03 06:23:00]

Peer review is fine

[tanvir, 2017-05-03 06:23:44]

tanvir.rizvi@samsung.com changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[tanvir, 2017-05-03 06:23:54]

PTAL!

[Xiaocheng, 2017-05-03 14:51:16]

xiaochengh@chromium.org changed reviewers:
+ eae@chromium.org

[Xiaocheng, 2017-05-03 14:51:17]

+eae

lgtm

https://codereview.chromium.org/2853343003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutText.cpp (right):

https://codereview.chromium.org/2853343003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutText.cpp:537: FloatRect rect =
LocalQuadForTextBox(box, start, end, false);
Please also remove the parameter from LocalQuadForTextBox and
AbsoluteRectsForRange.

Or you can choose to remove it in another patch. It doesn't matter that much.

[eae, 2017-05-03 15:14:38]

Very nice, LGTM once you have addressed Xiaochengs comments.

[tanvir, 2017-05-04 05:44:37]

On 2017/05/03 14:51:17, Xiaocheng wrote:
> +eae
> 
> lgtm
> 
>
https://codereview.chromium.org/2853343003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/layout/LayoutText.cpp (right):
> 
>
https://codereview.chromium.org/2853343003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/layout/LayoutText.cpp:537: FloatRect rect =
> LocalQuadForTextBox(box, start, end, false);
> Please also remove the parameter from LocalQuadForTextBox and
> AbsoluteRectsForRange.
> 
> Or you can choose to remove it in another patch. It doesn't matter that much.

I will remove it in another Patch. Thanks for the review.

[tanvir, 2017-05-04 05:44:58]

The CQ bit was checked by tanvir.rizvi@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 05:45:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 07:45:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 07:45:12]

Dry run: This issue passed the CQ dry run.

[tanvir, 2017-05-04 08:54:20]

The CQ bit was checked by tanvir.rizvi@samsung.com

[commit-bot: I haz the power, 2017-05-04 08:54:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 08:57:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493888060150430, "parent_rev":
"b49d34931454bc1fdffdba99d6a0b344430746b5", "commit_rev":
"d463bb0d71db8246590f488ba5dba62e3ae56876"}

[commit-bot: I haz the power, 2017-05-04 08:57:54]

Description was changed from

==========
Remove use_selection_height from LayoutText::AbsoluteQuadsForRange

All calls to LayoutText::AbsoluteQuadsForRange don't use use_selection_height,
so use_selection_height is removed from LayoutText::AbsoluteQuadsForRange and
its callee functions.

BUG=691198
==========

to

==========
Remove use_selection_height from LayoutText::AbsoluteQuadsForRange

All calls to LayoutText::AbsoluteQuadsForRange don't use use_selection_height,
so use_selection_height is removed from LayoutText::AbsoluteQuadsForRange and
its callee functions.

BUG=691198

Review-Url: https://codereview.chromium.org/2853343003
Cr-Commit-Position: refs/heads/master@{#469295}
Committed:
https://chromium.googlesource.com/chromium/src/+/d463bb0d71db8246590f488ba5db...
==========

[commit-bot: I haz the power, 2017-05-04 08:57:55]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d463bb0d71db8246590f488ba5db...