Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2853333003: Print preview: Migrate compiled_resources to newer syntax. (Closed)

Created:
3 years, 7 months ago by dpapad
Modified:
3 years, 7 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-closure_chromium.org, jlklein+watch-closure_chromium.org, vitalyp+closure_chromium.org, rbpotter
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Print preview: Migrate compiled_resources to newer syntax. BUG=717620 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2853333003 Cr-Commit-Position: refs/heads/master@{#468809} Committed: https://chromium.googlesource.com/chromium/src/+/3a84d089e30c91a7dccc584c20c4f54c9b543da3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
D chrome/browser/resources/print_preview/compiled_resources.gyp View 1 chunk +0 lines, -25 lines 0 comments Download
A chrome/browser/resources/print_preview/compiled_resources2.gyp View 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/closure_compiler/compiled_resources2.gyp View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
dpapad
FYI, currently getting 278 errors and 2 warnings.
3 years, 7 months ago (2017-05-02 21:08:37 UTC) #4
Dan Beam
lgtm
3 years, 7 months ago (2017-05-02 22:35:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853333003/1
3 years, 7 months ago (2017-05-02 22:59:59 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 23:04:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3a84d089e30c91a7dccc584c20c4...

Powered by Google App Engine
This is Rietveld 408576698