Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2853333002: Add performance test for ImageData.dataUnion (Closed)

Created:
3 years, 7 months ago by zakerinasab
Modified:
3 years, 7 months ago
CC:
chromium-reviews, blink-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add performance test for ImageData.dataUnion In codereview.chromium.org/2855683002/ the performace test for ImageData.dataUnion was removed as it was failing on try-bots. To make it work, we need both --enable-experimental-canvas-features and --enable-color-correct-rendering flags to be enabled in blink_perf.py. This CL fixes this and puts the perf test back. BUG=717549 Review-Url: https://codereview.chromium.org/2853333002 Cr-Commit-Position: refs/heads/master@{#468764} Committed: https://chromium.googlesource.com/chromium/src/+/4c4a925b1a047a296b7962566ff63918f3eba1c4

Patch Set 1 #

Patch Set 2 : Moving --enable-color-correct-rendering to blink_perf.canvas #

Patch Set 3 : Rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -0 lines) Patch
A third_party/WebKit/PerformanceTests/Canvas/getImageDataColorManaged.html View 1 2 1 chunk +92 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/blink_perf.py View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
nednguyen
On 2017/05/02 15:45:54, zakerinasab wrote: > mailto:zakerinasab@chromium.org changed reviewers: > + mailto:junov@chromium.org, mailto:nednguyen@google.com lg2me. I ...
3 years, 7 months ago (2017-05-02 16:30:32 UTC) #3
Justin Novosad
This is excellent lgtm
3 years, 7 months ago (2017-05-02 18:28:24 UTC) #4
nednguyen
On 2017/05/02 18:28:24, Justin Novosad wrote: > This is excellent > > lgtm Can this ...
3 years, 7 months ago (2017-05-02 18:30:07 UTC) #5
Justin Novosad
On 2017/05/02 18:30:07, nednguyen wrote: > On 2017/05/02 18:28:24, Justin Novosad wrote: > > This ...
3 years, 7 months ago (2017-05-02 18:34:18 UTC) #6
nednguyen
On 2017/05/02 18:34:18, Justin Novosad wrote: > On 2017/05/02 18:30:07, nednguyen wrote: > > On ...
3 years, 7 months ago (2017-05-02 18:36:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853333002/40001
3 years, 7 months ago (2017-05-02 18:46:04 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 20:34:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4c4a925b1a047a296b7962566ff6...

Powered by Google App Engine
This is Rietveld 408576698