Moving mojo/validation test into LayoutTests

mojo/public/interfaces/bindings/tests/BUILD.gn

Index: mojo/public/interfaces/bindings/tests/BUILD.gn
diff --git a/mojo/public/interfaces/bindings/tests/BUILD.gn b/mojo/public/interfaces/bindings/tests/BUILD.gn
index e496eb656c0f16063a48630c66e826207c815f25..5ed7b51dbc75ded601f7195099c022f678151dcc 100644
--- a/mojo/public/interfaces/bindings/tests/BUILD.gn
+++ b/mojo/public/interfaces/bindings/tests/BUILD.gn
@@ -4,6 +4,44 @@
 
 import("../../../tools/bindings/mojom.gni")
 
+group("tests") {

[Dirk Pranke, 2017/05/03 20:30:33]

Nit: I'd usually think "tests" referred to a list of test executables, but this
looks like this is all data files.

"test_data" would probably be a better name, but of course you're using that
further down, and I'm not coming up with a better set of names offhand.

[alokp, 2017/05/04 21:05:28]

You are right and this is something I want to fix. We used to have a bunch of
tests in this directory, but they have now been moved to
third_party/WebKit/LayoutTests/mojo. Once this patch lands, this directory will
only contain test interfaces and data, in which case it should be renamed to
"test", which might be a better target name than "tests".

+  testonly = true
+  deps = [
+    ":test_interfaces",
+  ]
+  data_deps = [
+    ":test_data",
+    ":test_data_list",
+  ]
+}
+
+copy("test_data") {
+  testonly = true
+  sources = [
+    "data/validation",
+  ]
+  outputs = [
+    "$root_gen_dir/layout_test_data/{{source_root_relative_dir}}/{{source_file_part}}",
+  ]
+}
+
+action_foreach("test_data_list") {
+  testonly = true
+  script = "//mojo/public/tools/bindings/gen_data_files_list.py"
+  sources = [
+    "data/validation",
+  ]
+  outputs = [
+    "$root_gen_dir/layout_test_data/{{source_root_relative_dir}}/{{source_file_part}}/index.txt",

[yzshen1, 2017/05/03 05:48:23]

What is {{source_file_part}} in this case? Is it "validation"?

[alokp, 2017/05/03 06:09:15]

Yes. This resolves to
$root_gen_dir/layout_test_data/mojo/public/interfaces/bindings/tests/data/validation/index.txt

+  ]
+  args = [
+    "-d",
+    rebase_path(sources[0], root_build_dir),
+    "-o",
+    rebase_path(outputs[0], root_build_dir),
+  ]
+}
+
 mojom("test_interfaces") {
   testonly = true
   sources = [