Moving mojo/validation test into LayoutTests

Moving mojo/validation test into LayoutTests

BUG=647036
TBR=yzshen,dpranke,jbroman

Review-Url: https://codereview.chromium.org/2853293003
Cr-Commit-Position: refs/heads/master@{#469506}
Committed: https://chromium.googlesource.com/chromium/src/+/577b29ee4f96b770e486a3b1e54c510e08bd7956

[alokp, 2017-05-02 19:39:33]

The CQ bit was checked by alokp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 19:39:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 21:53:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 21:53:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alokp, 2017-05-03 00:05:22]

The CQ bit was checked by alokp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 00:06:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 02:38:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 02:38:21]

Dry run: This issue passed the CQ dry run.

[alokp, 2017-05-03 04:13:00]

Description was changed from

==========
Moving mojo/validation test into LayoutTests

part of the move started in Issue 2744763002
This moves the validation test

BUG=647036
==========

to

==========
Moving mojo/validation test into LayoutTests

BUG=647036
TBR=yzshen,dpranke,jbroman
==========

[alokp, 2017-05-03 04:13:00]

alokp@chromium.org changed reviewers:
+ dpranke@chromium.org, jbroman@chromium.org, yzshen@chromium.org

[alokp, 2017-05-03 04:13:35]

This patch has already been reviewed here:
https://codereview.chromium.org/2745293005/

[alokp, 2017-05-03 04:13:36]

This patch has already been reviewed here:
https://codereview.chromium.org/2745293005/

[alokp, 2017-05-03 04:15:08]

This patch has already been reviewed here:
https://codereview.chromium.org/2745293005/

damargulis@ tenure is over, so I have taken over the patch and fixed the test
failure on linux. The original patch is patch set 1. The fixes are in patch set
2. Patch set 3 just removes debug logging.

[alokp, 2017-05-03 04:15:18]

The CQ bit was checked by alokp@chromium.org

[commit-bot: I haz the power, 2017-05-03 04:15:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 05:30:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 05:30:36]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yzshen1, 2017-05-03 05:48:23]

LGTM as long as the GN magic works. :)

https://codereview.chromium.org/2853293003/diff/40001/mojo/public/interfaces/...
File mojo/public/interfaces/bindings/tests/BUILD.gn (right):

https://codereview.chromium.org/2853293003/diff/40001/mojo/public/interfaces/...
mojo/public/interfaces/bindings/tests/BUILD.gn:35:
"$root_gen_dir/layout_test_data/{{source_root_relative_dir}}/{{source_file_part}}/index.txt",
What is {{source_file_part}} in this case? Is it "validation"?

[alokp, 2017-05-03 06:09:15]

https://codereview.chromium.org/2853293003/diff/40001/mojo/public/interfaces/...
File mojo/public/interfaces/bindings/tests/BUILD.gn (right):

https://codereview.chromium.org/2853293003/diff/40001/mojo/public/interfaces/...
mojo/public/interfaces/bindings/tests/BUILD.gn:35:
"$root_gen_dir/layout_test_data/{{source_root_relative_dir}}/{{source_file_part}}/index.txt",
On 2017/05/03 05:48:23, yzshen1 wrote:
> What is {{source_file_part}} in this case? Is it "validation"?

Yes. This resolves to
$root_gen_dir/layout_test_data/mojo/public/interfaces/bindings/tests/data/validation/index.txt

[alokp, 2017-05-03 06:09:22]

The CQ bit was checked by alokp@chromium.org

[commit-bot: I haz the power, 2017-05-03 06:09:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 07:33:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 07:33:11]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Dirk Pranke, 2017-05-03 20:30:33]

lgtm

https://codereview.chromium.org/2853293003/diff/40001/mojo/public/interfaces/...
File mojo/public/interfaces/bindings/tests/BUILD.gn (right):

https://codereview.chromium.org/2853293003/diff/40001/mojo/public/interfaces/...
mojo/public/interfaces/bindings/tests/BUILD.gn:7: group("tests") {
Nit: I'd usually think "tests" referred to a list of test executables, but this
looks like this is all data files.

"test_data" would probably be a better name, but of course you're using that
further down, and I'm not coming up with a better set of names offhand.

[alokp, 2017-05-04 21:05:28]

https://codereview.chromium.org/2853293003/diff/40001/mojo/public/interfaces/...
File mojo/public/interfaces/bindings/tests/BUILD.gn (right):

https://codereview.chromium.org/2853293003/diff/40001/mojo/public/interfaces/...
mojo/public/interfaces/bindings/tests/BUILD.gn:7: group("tests") {
On 2017/05/03 20:30:33, Dirk Pranke (slow until May 4) wrote:
> Nit: I'd usually think "tests" referred to a list of test executables, but
this
> looks like this is all data files.
> 
> "test_data" would probably be a better name, but of course you're using that
> further down, and I'm not coming up with a better set of names offhand.

You are right and this is something I want to fix. We used to have a bunch of
tests in this directory, but they have now been moved to
third_party/WebKit/LayoutTests/mojo. Once this patch lands, this directory will
only contain test interfaces and data, in which case it should be renamed to
"test", which might be a better target name than "tests".

[alokp, 2017-05-04 21:14:28]

The CQ bit was checked by alokp@chromium.org

[alokp, 2017-05-04 21:14:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2853293003/#ps60001
(title: "moves index file outside data dir")

[commit-bot: I haz the power, 2017-05-04 21:15:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 23:10:13]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493932468746260,
"parent_rev": "56aabec6e1277dde13b944d01e2fc2337c1cebf3", "commit_rev":
"577b29ee4f96b770e486a3b1e54c510e08bd7956"}

[commit-bot: I haz the power, 2017-05-04 23:10:39]

Description was changed from

==========
Moving mojo/validation test into LayoutTests

BUG=647036
TBR=yzshen,dpranke,jbroman
==========

to

==========
Moving mojo/validation test into LayoutTests

BUG=647036
TBR=yzshen,dpranke,jbroman

Review-Url: https://codereview.chromium.org/2853293003
Cr-Commit-Position: refs/heads/master@{#469506}
Committed:
https://chromium.googlesource.com/chromium/src/+/577b29ee4f96b770e486a3b1e54c...
==========

[commit-bot: I haz the power, 2017-05-04 23:10:40]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/577b29ee4f96b770e486a3b1e54c...