Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2853273004: Remove DocumentActivityTestBase (Closed)

Created:
3 years, 7 months ago by the real yoland
Modified:
3 years, 7 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, newt (away)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DocumentActivityTestBase DocumentActivityTestBase is not used by any test class, in JUnit4, a test that requires DocumentActivity can use `ChromeActivityTestRule<DocumentActivity>` BUG=640116 Review-Url: https://codereview.chromium.org/2853273004 Cr-Commit-Position: refs/heads/master@{#468877} Committed: https://chromium.googlesource.com/chromium/src/+/c9c0d96118b8381d85b0f311c4d2497d5b5373dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M chrome/test/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/android/javatests/src/org/chromium/chrome/test/DocumentActivityTestBase.java View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
the real yoland
+cc newt@ as the last person who changed the base class
3 years, 7 months ago (2017-05-03 01:06:05 UTC) #2
jbudorick
lgtm
3 years, 7 months ago (2017-05-03 01:08:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853273004/1
3 years, 7 months ago (2017-05-03 01:09:32 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 02:58:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c9c0d96118b8381d85b0f311c4d2...

Powered by Google App Engine
This is Rietveld 408576698